1174731 - Make searchParams attribute readonly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Anne (:annevk)]

This would significantly simplify the complexity of the object and not really reduce the functionality.

Comment 1

[Anne (:annevk)]

(I will update the specification if this is successful, as far as I know we're still the only ones implementing this.)

Comment 2

[Anne (:annevk)]

To clarify, the reason the specification is not changed is because this rather simplifies URLSearchParams as the relationship to URL objects becomes 1:1. I'd like to make sure we can land this without issue as otherwise I end up changing the specification twice.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: usp2.patch

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Anne, is the idea then to have something like .clear() in URLSearchParams?
Though, I guess one can always use url.search = "";

Comment 5

[Anne (:annevk)]

Yeah, we could add new methods later. Need to figure out what kind of methods make sense for multimap objects. Note that FormData/URLSearchParams/Headers are extremely close in terms of API.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: usp3.patch

Comment 7

[Anne (:annevk)]

Comment on attachment 8625778 [details] [diff] [review]
usp3.patch

Review of attachment 8625778 [details] [diff] [review]:
-----------------------------------------------------------------

Please lose the indentation so that the word "attribute" is aligned with the lines before. Also, this should be a new URLUtilsSearchParams interface, no?

Comment 8

[Andrea Marchesini [:baku]]

Attachment: usp3.patch

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c93813baadc
https://hg.mozilla.org/integration/mozilla-inbound/rev/44002ebe4e2c

Comment 10

[Andrea Marchesini [:baku]]

Comment on attachment 8625786 [details] [diff] [review]
usp3.patch

I received a r+ from annevk in 'real life'.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c93813baadc
https://hg.mozilla.org/mozilla-central/rev/44002ebe4e2c

Comment 12

[Anne (:annevk)]

https://www.w3.org/Bugs/Public/show_bug.cgi?id=27596 will fix this specification-wise.

Comment 13

[Kohei Yoshino]

It breaks my BzDeck app :(

https://github.com/bzdeck/bzdeck/blob/master/webroot/static/scripts/controllers/base.js#L21

Why searchParams is readonly even on new URL?

Comment 14

[Anne (:annevk)]

> Why searchParams is readonly even on new URL?

Because 1:1 is much better than 1:M and you can simply assign to .search instead.

Comment 15

[Kohei Yoshino]

Thanks, url.search works for me. 
https://github.com/bzdeck/bzdeck/commit/c0841f7f0bfe17fac71b606be6b3777049aea6dc

Documented on the site compat doc.
https://developer.mozilla.org/en-US/Firefox/Releases/41/Site_Compatibility#DOM