1105889 - Libpurple proxy preferences are broken

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[aleth [:aleth]]

STR

1) Try to enter proxy details, and try to click OK: This fails.
00:17:49 - Fearful: Error: NS_ERROR_XPC_BAD_CONVERT_JS: Could not convert JavaScript argument arg 0 [purpleICoreService.globalProxy]
00:17:52 - Fearful: Source File: chrome://instantbird/content/proxies.js
00:17:54 - Fearful: Line: 169

2) Try to click on one of the other two options for the proxy settings, and try to click OK: This also fails.
Timestamp: 28/11/2014 00:25:20
Error: NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [purpleICoreService.getProxies]
Source File: chrome://instantbird/content/proxies.js
Line: 50
Timestamp: 28/11/2014 00:25:37
Error: NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [purpleICoreService.globalProxy]
Source File: chrome://instantbird/content/proxies.js
Line: 163

Comment 1

[aleth [:aleth]]

Attachment: Part 1 - purplexpcom [already checked in]

This patch fixes 1)

Comment 2

[aleth [:aleth]]

Attachment: Part 2 - ensure initialization

Fixes 2). It is possible for the purpleCoreService not to be already initialized if there are no libpurple accounts and the account wizard has not been opened.

Comment 3

[aleth [:aleth]]

Attachment: Part 2 - ensure initialization v2

Comment 4

[aleth [:aleth]]

http://hg.mozilla.org/users/florian_queze.net/purple/rev/97fdf172fc98

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/58d30b444f8c

Comment 6

[Patrick Cloke [:clokep]]

Thanks for taking a look at this! :)