1105977 - [FFOS2.0][Woodduck][SMS]The discard function is wrong.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[sync-1]

Created an attachment (id=1007579)
    
 
 DEFECT DESCRIPTION:
 KO1：There is old draft content display in new sms interface.
 KO2:the draft icon still display in the old conversation.
 
  REPRODUCING PROCEDURES:
 1.Go to sms,send or receive a sms with the sender's numbers(e.g 10010),new a draft in this conversation,save it.
 2.View this conversation messages,touch the number(10010) in message content->Send message->pop up the "Unsent message"message,select "Discard"->enter to a new sms interface--KO1
 3.Back to conversation list.--KO2
 
 >备注：若第一步中，新建保存的Draft是彩信存在相同问题.
 
  EXPECTED BEHAVIOUR:
 KO1：The draft should not be display in new sms interface,and MS should only display send a new sms to the recepient.
 KO2:There should no draft icon display.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:2611692(61692).
 
 KO1： is ok now,KO2:is not ok as shown in figure

Comment 1

[Josh Cheng [:josh]]

Hi Gary,
Could you please help to check the problem? Thanks!

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

qawanted for branch checks as well.

Comment 3

[Cody Roesch [:croesch]]

Hi Josh,
   I'm having difficulty understanding the reporters steps on this bug due to the way it is written in english. It does not make sense when I try to run them on the Flame device. 

Are you or anyone else available to help rewrite the steps better so that we may understand exactly how to try to reproduce this?

Also due to multiple KO results does this mean they are seeing multiple bugs?

Thank you very much!
QA

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I have been unable to get a discarded draft to remain on Flame 2.2, Flame 2.1, or Flame 2.0.  The message always discards and the conversation does not show the draft icon when viewed in the conversation list.

If this is not what this issue is about, please add the qawanted tag again with the information requested in comment 3.

Environmental Variables:
Device: Flame 2.2
BuildID: 20141209040946
Gaia: 9e0b96c7b61c7ff943876ca93e2596d972437b80
Gecko: 47f0671e2c65
Version: 37.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Environmental Variables:
Device: Flame 2.1
BuildID: 20141209084847
Gaia: 155424d51cf9bb2ea41dc6667f94741f82f35bc0
Gecko: fe5329227c54
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0
BuildID: 20141208061237
Gaia: 856863962362030174bae4e03d59c3ebbc182473
Gecko: 2d0860bd0225
Version: 32.0 (2.0) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 5

[sync-1]

this is in [FFOS2.0][Woodduck]
 REPRODUCING PROCEDURES:
 
 1.Go to sms,send or receive a sms with the sender's numbers(e.g 10010),new a
 draft in this conversation,save it.
 2.View this conversation messages,touch the number(10010) in message
 content->Send message->pop up the "Unsent message"message,select
 "Discard"->enter to a new sms interface
 3.Back to conversation list.
 
 NOW KO1 is ok,you can only check the KO2,the KO2 is not ok.
  
 When "Back to conversation list",here should no draft icon display,But now has draft and  icon display ,View this conversation messages,the draft can not be seed.

Comment 6

[Josh Cheng [:josh]]

Hi Peipei,
Can you help to provide accurate STR per comment 5? Thanks!

Comment 7

[Peipei Cheng (needinfo if you need my action)]

Attachment: 1105977.3gp

Please see attached STR video.

Reproduce steps:
-----------------------------------------------------------------------
0. prepare a test mobile number (e.g. 10010 in my test)
1. Launch SMS and create a new message
2. input "10010" in both "To" field and "Message body", then send it
3. Stay in the current conversation
4. Tap on Message body and input some message
5. Tap on button "<", and select "Save as Draft"
6. go back to message conversation with 10010
7. Tap on "10010" in the message body of Step 2
8. Select "Send message", "Unsent Message" message appears
9. Select "Discard", a new message is started
10. Tap on "<" button to return to message list and select "Discard"
    --> You will see draft icon displays. View this conversation messages,there is no draft.

Comment 8

[Peipei Cheng (needinfo if you need my action)]

Norry,
could you please help check whether this is reproducible on Flame 2.0/2.1/2.2? The reproduce steps is in comment 7.

Comment 9

[Cody Roesch [:croesch]]

With the steps in Comment 7, I was able to understand and complete the testing for the Flame. Leaving QAWanted tag for Norry's results.

Tested with Shallow Flash on 319mb using Engineering builds.

This bug repro's on Flame KK builds: Flame 2.2 KK, Flame 2.1 KK, Flame 2.0 KK, Flame V188-1 Base

Actual Results: Message thread shows it is in draft form when in actuality it is not when the message is viewed.

Repro Rate: 4/4

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141209040946
Gaia: 9e0b96c7b61c7ff943876ca93e2596d972437b80
Gecko: 47f0671e2c65
Version: 37.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141209014645
Gaia: 89421df25ca321f2f4c152dd6e2146cf18b00f06
Gecko: 74fd011aacbf
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141208061237
Gaia: 856863962362030174bae4e03d59c3ebbc182473
Gecko: 2d0860bd0225
Version: 32.0 (2.0) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame v188-1 Base
BuildID: 20141021162107
Gaia: 8c5c956ee6909408e29f375cc7d843a03d92f3d8
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 10

[Sue]

Attachment: video.MP4

After executing the steps of comment 7, this issue could be reproduced on Flame 2.0/2.1/2.2
We could found after step 9, there are two receivers(two 10010 for example) at "To" field on Flame 2.0 and Flame 2.1. But on Flame 2.2, there is only one receiver. After step 10, there is a draft icon, view this conversation messages, there is no draft. 
I have uploaded video and logcat of flame 2.1
Found time: 14:16
Please check it, thanks.

Comment 11

[Sue]

Attachment: logcat of Flame 2.1

Comment 12

[Sue]

Flame 2.0 versions:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/2d0860bd0225
Build-ID        20141210000202
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141210.034839
FW-Date         Wed Dec 10 03:48:50 EST 2014
Bootloader      L1TC00011880

Flame 2.1 versions:
Gaia-Rev        c226db212db4d824c09617cd6dc407b2d4258d9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/cf8bebfa4703
Build-ID        20141210001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141210.035300
FW-Date         Wed Dec 10 03:53:11 EST 2014
Bootloader      L1TC00011880

Flame 2.2 versions:
Gaia-Rev        e17c5656dbf517d48fb61ac9bc92119e023fd717
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/be1f49e80d2d
Build-ID        20141210040201
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141210.074809
FW-Date         Wed Dec 10 07:48:20 EST 2014
Bootloader      L1TC00011880

Comment 13

[Josh Cheng [:josh]]

Hi Luke,
Could you please help to check the problem? Thanks!

Comment 14

[Luke Chang [:lchang] (inactive)]

Attachment: Pull request to master

Hi Steve,

Could you please help reviewing this patch? Thanks.

Comment 15

[Steve Chung [:steveck]]

Comment on attachment 8535533 [details] [review]
Pull request to master

Hi Luke, this patch looks good and only one nit for it. Thanks for fixing this general issue!

Comment 16

[Luke Chang [:lchang] (inactive)]

Hi Steve, 

Thanks for the review and I'll update my patch.

Comment 17

[Luke Chang [:lchang] (inactive)]

Attachment: Pull request to v2.0m

Comment 18

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8535533 [details] [review]
Pull request to master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): general issue.
[User impact] if declined: an incorrect draft icon shown on a empty thread.
[Testing completed]: yes.
[Risk to taking this patch] (and alternatives if risky): very low.
[String changes made]: N/A

Comment 19

[Luke Chang [:lchang] (inactive)]

landed on master: https://github.com/mozilla-b2g/gaia/commit/04c256b7f00b44939d9f4932509ef97702241886
landed on v2.0m: https://github.com/mozilla-b2g/gaia/commit/f7a4fe9083c961c07baed55e469570a1dbcdebf6

Comment 20

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8535533 [details] [review]
Pull request to master

Sorry, wrong pull request.

Comment 21

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8536997 [details] [review]
Pull request to v2.0m

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): general issue.
[User impact] if declined: an incorrect draft icon shown on a empty thread.
[Testing completed]: yes.
[Risk to taking this patch] (and alternatives if risky): very low.
[String changes made]: N/A

Comment 22

[bhavana bajaj [:bajaj]]

Comment on attachment 8536997 [details] [review]
Pull request to v2.0m

please verify once this lands on 2.1

Comment 23

[sync-1]

已经验证通过，但是代码还没有合入，看是等mozilla或者是MTK那边统一合入，还是有我这边合入。

Comment 24

[Josh Cheng [:josh]]

(In reply to sync-1 from comment #23)
> 已经验证通过，但是代码还没有合入，看是等mozilla或者是MTK那边统一合入，还是有我这边合入。

We will land code on GitHub which MTK will sync with it then release to you. You do not need to merge the code yourself.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/6a983f2207d7bf7665a7ed48588d6bc4f38fc412

Comment 26

[Shine(Leave from Mozilla)]

Attachment: Verify video

With the steps in Comment 7, the problem is verified not happen on Woodduck 2.0/Flame 2.1/Flame 2.2.
See attachment: Verify_video.MP4
Reproducing rate: 0/5

Woodduck 2.0 Build:
Gaia-Rev        ef37eb354bbde5837211b22dfdc0eed9623ade0e
Gecko-Rev       c9a727cb1d1ea0b5a82c64a360c03dbc35421d59
Build-ID        20141222050313
Version         32.0

Flame 2.1 build:
Gaia-Rev        6af3d029bae3a14f400fec0926f0f8ad7b579b4b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/39eaa987093b
Build-ID        20141221001202
Version         34.0

Flame 2.2 build:
Gaia-Rev        ca6e91e09ef3ab417a0f6b6d6668d43597d85700
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/7b33ee7fd162
Build-ID        20141221040207
Version         37.0a1

Comment 27

[Shine(Leave from Mozilla)]

Per comment 26, clear the verifyme flag.