1105985 - [Stingray][Home] Rearrange mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We need to implement rearrange mode under edit mode that
- When selecting an item, the cursor is  "snapped" to it. User can move
  the item around to a new place where he/she wants to.
- When moving to an item, the selected item just switch its position with target item.
- When moving to a folder, the selected item stops above the folder and let user choice if he/she want to move the item into folder, or just press left/right again to just switch position with the item.
- User presses enter to end the rearrange mode and thus confirm item's new position.

Since this behavior is not considered by SpatialNavigator, we may need to improve the implementation of SpatialNavigator depends on situations we encountered

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

This patch contains 
1. entering edit mode
2. rearrange mode
3. some visual applied to navigation bar of edit mode
4. Some css fix on app-deck due to changes in scrollable.js.

dwi2: May you help review this patch? I ended up writing "edit mode" with "arrange mode" together since they're highly related. If you find it difficult to review please let me know. (You may leave smart-buttons for John)

John: Since I added a few types to smart-button and nested the app-button inside a div (for delete and rename button, although they're not functional yet) may you take a look on that?

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8538425 [details] [review]
Patch

f- because a regression found. Please find the comments at PR. The suggested code is at there, too.

Suggestion:
*. If possible, please move the code related to edit and rearrange to another class.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Extra Suggests:
*. If possible, add the "background-image" support to "text-and-icon" button. This patch only have "data-icon" rules instead of rules related to "background-image".
*. If possible, add underlined-text and text-and-icon example to examples folder.
  <smart-button type="underlined-text">This is a TEST</smart-button><br>
  <smart-button type="text-and-icon" id="text-and-icon">This is a TEST</smart-button>

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8538425 [details] [review]
Patch

I've put my comment on PR. I am OK with most part of the code. But since John has some concern, I'd like to have a second round of review after John's comments are addressed. 

Thanks

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8538425 [details] [review]
Patch

I've just made changes based on comments.
dwi2 and John may you take a look again?

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8538425 [details] [review]
Patch

Looks good to me.

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8538425 [details] [review]
Patch

Looks good to me, thanks

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/2e9eb41c12aed131d2d10b860641ddfd088bcb8a