Callscreen answer/reject buttons are misaligned in RTL

VERIFIED FIXED in 2.2 S3 (9jan)

Status

defect
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

unspecified
2.2 S3 (9jan)
Dependency tree / graph
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(b2g-v2.2 verified)

Details

(Whiteboard: [c=1])

Attachments

(4 attachments)

Assignee

Description

5 years ago
Posted image Screenshot
The answer button in RTL mode is pushed too far to the left and is slightly too large. This is likely a simple padding/margin issue.
Assignee

Updated

5 years ago
Component: Gaia::E-Mail → Gaia::Dialer
Assignee

Comment 2

5 years ago
Carol, I adjusted the visuals of the answer/reject buttons in both LTR and RTL modes as I noticed that they were slightly off in both cases. Let me know if you'd like to make any adjustments.
Attachment #8530464 - Flags: ui-review?(chuang)
Any updates here? :)
Flags: needinfo?(drs.bugzilla)
Assignee

Comment 4

5 years ago
Comment on attachment 8530463 [details] [diff] [review]
Align answer/reject buttons on Callscreen, incl. RTL support.

I'll take this to completion since it's already almost done. Gabriele, please review this since Germán is on PTO.

Carol, please complete the UI review requested in comment 2, as this is still relevant.
Flags: needinfo?(drs.bugzilla) → needinfo?(chuang)
Attachment #8530463 - Flags: review?(gtorodelvalle) → review?(gsvelto)
Comment on attachment 8530463 [details] [diff] [review]
Align answer/reject buttons on Callscreen, incl. RTL support.

LGTM and I find having unified the callbar-hang-up and callbar-answer generic margins rather elegant.
Attachment #8530463 - Flags: review?(gsvelto) → review+
Hi Doug,
Thanks for the button adjustment!they look much better.

by the way, I wonder if you can also help on tweaking the layout because "via Sim1" and "Incoming call icon" should be on the opposite side of the screen(on RTL).
Thanks!!
Flags: needinfo?(chuang)
Attachment #8530464 - Flags: ui-review?(chuang) → ui-review+
Assignee

Comment 7

5 years ago
https://github.com/mozilla-b2g/gaia/commit/883980f52158c47cd7a4cbdc87c4557dd3b9e3cd

(In reply to Carol Huang [:Carol] from comment #6)
> Hi Doug,
> Thanks for the button adjustment!they look much better.
> 
> by the way, I wonder if you can also help on tweaking the layout because
> "via Sim1" and "Incoming call icon" should be on the opposite side of the
> screen(on RTL).
> Thanks!!

That's being handled in bug 1106168.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: 2.2 S1 (5dec) → 2.2 S3 (9jan)

Updated

5 years ago
Keywords: verifyme

Updated

5 years ago
Status: RESOLVED → VERIFIED
Keywords: verifyme

Comment 8

5 years ago
This issue verified successfully on Flame 2.2
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ce27f2692382
Build-ID        20150115002505
Version         37.0a2
Reproduce rate 0/5

Updated

5 years ago
Flags: in-moztrap+
You need to log in before you can comment on or make changes to this bug.