1106185 - Callscreen answer/reject buttons are misaligned in RTL

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

The answer button in RTL mode is pushed too far to the left and is slightly too large. This is likely a simple padding/margin issue.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Align answer/reject buttons on Callscreen, incl. RTL support.

PR: https://github.com/mozilla-b2g/gaia/pull/26564

Comment 2

[Doug Sherk (:drs) (inactive)]

Attachment: Proposed visual design after fix

Carol, I adjusted the visuals of the answer/reject buttons in both LTR and RTL modes as I noticed that they were slightly off in both cases. Let me know if you'd like to make any adjustments.

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Any updates here? :)

Comment 4

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8530463 [details] [diff] [review]
Align answer/reject buttons on Callscreen, incl. RTL support.

I'll take this to completion since it's already almost done. Gabriele, please review this since Germán is on PTO.

Carol, please complete the UI review requested in comment 2, as this is still relevant.

Comment 5

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8530463 [details] [diff] [review]
Align answer/reject buttons on Callscreen, incl. RTL support.

LGTM and I find having unified the callbar-hang-up and callbar-answer generic margins rather elegant.

Comment 6

[Carol Huang [:Carol]]

Hi Doug,
Thanks for the button adjustment!they look much better.

by the way, I wonder if you can also help on tweaking the layout because "via Sim1" and "Incoming call icon" should be on the opposite side of the screen(on RTL).
Thanks!!

Comment 7

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/883980f52158c47cd7a4cbdc87c4557dd3b9e3cd

(In reply to Carol Huang [:Carol] from comment #6)
> Hi Doug,
> Thanks for the button adjustment!they look much better.
> 
> by the way, I wonder if you can also help on tweaking the layout because
> "via Sim1" and "Incoming call icon" should be on the opposite side of the
> screen(on RTL).
> Thanks!!

That's being handled in bug 1106168.

Comment 8

[Elie]

Attachment: ^919FE01AD2A18AB239E438FB1EE965751F28C76A5ACD6B1BA0^pimgpsh_fullsize_distr.jpg

This issue verified successfully on Flame 2.2
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ce27f2692382
Build-ID        20150115002505
Version         37.0a2
Reproduce rate 0/5

Comment 9

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15426/