1106411 - [PrivacyPanel] Hide on the vertical home screen by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

Currently the privacy panel shows up on the home screen, and I don't think it's meant to.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1106411_privacy_panel_role to mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8530646 [details] [review]
[PullReq] KevinGrandon:bug_1106411_privacy_panel_role to mozilla-b2g:master

Marta or Etienne - could one of you review this? Thank you!

Comment 3

[marta]

Kevin,
It should. It is one of the pre-installed apps, and it should be accessible from both - the home screen and the settings...

Comment 4

[Kevin Grandon :kgrandon]

Hmm, I don't think we should have an entrypoint from the settings app *and* home screen. To me the current panel is designed to be entered from the settings app IMO, so that should be the primary entrypoint. 

Needinfo on Product people - should we access this from both settings and home screen?

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8530646 [details] [review]
[PullReq] KevinGrandon:bug_1106411_privacy_panel_role to mozilla-b2g:master

Flagging r+ because the code change is fine but this is indeed a product/UX decision.

Comment 6

[Kevin Grandon :kgrandon]

So I had a chat with Wilfred/Peter/Others, and it seems that we are not quite ready to have this app on the master home screen. It needs to be thought out more, and introduced properly into the home screen grid.

Also - we should build this in a way which can be included by partners into the build. It doesn't need to be part of the default, but we should be able to easily enable it for home screen.

I'm disabling this by default for now until we chat with UX/Product more to determine whether or not this should be on the home screen.

https://github.com/mozilla-b2g/gaia/commit/9147b757b9a01bbfe38adbf1eedffda31997a9d7

Comment 7

[Kevin Grandon :kgrandon]

Re-opening as this was reverted in bug 1110118. We want to hide this by default as it's not quite polished yet. We should also allow operators to be able to customize and include it on the home screen if desired.

Comment 8

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1106411_pp_manifest_take2 to mozilla-b2g:master

Comment 9

[Kevin Grandon :kgrandon]

The above pull request is just the same one as before, just need to figure out why having role="system" is causing the task manager to barf.

Another approach I'm going to look at is creating a blacklist in the home screen configuration. That way it's easily configured by partners.

Comment 10

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1106411_pp_manifest_take3 to mozilla-b2g:master

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8543333 [details] [review]
[PullReq] KevinGrandon:bug_1106411_pp_manifest_take3 to mozilla-b2g:master

Hey Guys - just looking for a review here and not sure if anyone is on PTO for the holidays. Thanks for taking a look!

Comment 12

[Chris Lord [:cwiiis]]

Comment on attachment 8543333 [details] [review]
[PullReq] KevinGrandon:bug_1106411_pp_manifest_take3 to mozilla-b2g:master

I'm on PTO, but this is small and looks good. One comment on github, feel free to address it if you think it's valid.

Comment 13

[Kevin Grandon :kgrandon]

Thanks for the PTO-review, you are also bad at taking PTO :) I've addressed the comment, and will land when green.

Comment 14

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1106411_vertical_home_blacklist to mozilla-b2g:master

Comment 15

[Kevin Grandon :kgrandon]

I've submitted a new pull request here which hard-codes the app URL instead of being in the JSON file. This is not ideal, but I'm having a heck of a time with the configurator, and single variant in the current approach. I think I might land this initially and also start re-working the configurator, it's not very straightforward in how it works.

Comment 16

[Kevin Grandon :kgrandon]

Going with the simple approach for now, and if we get time we will make this configurable: https://github.com/mozilla-b2g/gaia/commit/3e066bdb5ab0266164cd634af1041c41ca30867d