1107128 - Adjust the wording of failed classification saves to be a bit more clear

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Jonathan French (:jfrench)]

Currently, the warning is:

"must be logged in to classify jobs"

I propose it be:

"must be logged in to save job classifications"

Since that is a bit more specific, and the action the user is doing when the error is triggered. As they already may have (in their mind) added a classification and/or related bug, in the available UI.

We might later consider to make parts of the UI like the related bugs field, the classification input, or its dropdown, unavailable (but visible) and provide guiding dialogs using user.loggedin like we do here
https://github.com/mozilla/treeherder-ui/blob/e6a61d346bbc5e107150f95b4e173c2cf4012c6d/webapp/app/partials/main/persona_buttons.html#L2

Perhaps cuing the user to log in via persona when they touch "login required" parts of the pinboard UI and aren't logged in. Maybe contextual popup tips that appear in each field on mouse down when not logged in. But that's a separate enhancement which could be encompassed in bug 1074939.

Comment 1

[Jonathan French (:jfrench)]

(In reply to Jonathan French (:jfrench) from comment #0)

> Perhaps cuing the user to log in via persona when they touch "login
> required" parts of the pinboard UI and aren't logged in. Maybe contextual
> popup tips that appear in each field on mouse down.

And in doing so, we reduce the likelihood of the user getting to this point, ie. of being in an invalid save condition.

Comment 2

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#287

Please see above PR for status and review.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Perhaps we should just open the Persona login if a not signed in user clicks Save?

Comment 4

[Jonathan French (:jfrench)]

I'd pose we'd want to use the existing warning dialogue, in the event they don't want to log in. The existing dialogue disappears on its own, whereas the Persona button requires manual dismissal.

Comment 5

[Jonathan French (:jfrench)]

We could linkify the "logged in" words in the existing dialogue message, to point to the persona login, in case that helps.

Although the existing Login/Register button in the navbar is pretty visible I guess.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Can we turn the login button red or something when an unauthenticated person clicks save?

Comment 7

[Jonathan French (:jfrench)]

That will be covered in bug 1074939; we intend to prevent an unauthenticated person from accessing the save button to begin with.

The save button will be dimmed and blocked (like the log viewer button is when log parsing is in progress).

At which point, it's possible these warning messages I've proposed we change for now, could in theory go away. Or perhaps they'd be kept in purely for debugging purposes.

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 8531637 [details] [review]
treeherder-ui-PR#287

Looks clearer, thank you :-)

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/c468401ba90ad00191a058c0ff446fea59a04af0
Bug 1107128 - Improve the failed classification save message

https://github.com/mozilla/treeherder-ui/commit/479f9da7ce0d93f366d3156a4734791e1e495c2d
Merge pull request #287 from tojonmz/save-classification-message

Bug 1107128 - Improve the failed classification save message

Comment 10

[Jonathan French (:jfrench)]

Verified fixed and working correctly on stage.

Comment 11

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/deb00abaddb6252a3c53061f8dc407d7191225f7
Bug 1107128 - Improve the failed classification save message

https://github.com/mozilla/treeherder/commit/c37aa09975d9c01c2a5f798677d9e546c57601e8
Merge pull request #287 from tojonmz/save-classification-message

Bug 1107128 - Improve the failed classification save message