1074939 - Classification "Save" button should be visible but greyed out (with helpful tooltip) rather than hidden

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Currently, if there is a reason why the failure classification cannot be saved, the save button is hidden - which makes it hard to figure out:
a) That there even is a save button (not obvious to new user)
b) What the reason is for not being able to save

Instead of hiding the save button, we should disable it, and display the red circle with a cross through it when you mouse over - along with a helpful reason (eg: "you are not logged in", or "there are no jobs pinned") - similar to how we disable the log viewer if the log isn't parsed.

Comment 1

[Jonathan French (:jfrench)]

I was thinking similarly today, w.r.t. the new persistent job panel resulting from bug 1074972. Making the save button block inside it persistent also will eliminate any major residual flashing. Nice Ed!

If possible, I wonder if we should dim the text in that save block? Make it sort of look like a pending job (roughly that level of grey, maybe a bit more readable than that) That way the user doesn't even have to navigate over there to discover its state. They'll just see it.

Comment 2

[Jonathan French (:jfrench)]

Gah, just re-read the Summary (was out of view as I was typing). We are on the same page :)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd argue this could be a p2 bug, just for stopping the annoyance where I click "save" to classify a failure, then accidentally click again where the "save" button used to be (now the "classification" textarea, since everything slide over to the right), so suddenly my n/p or j/k keyboard commands to move on to another failure just type text into the "classification" textarea, making me then empty out the classification box, click outside of the textarea (often by clicking some white space up in the pushlog section of treeherder, losing my position in the list of failures in the process), then going on from there.

Seems like it wouldn't be too hard to do this, so "patches welcome" would be a perfectly acceptable response, and I might even do that if this hits me too many more times. :)

Comment 4

[Jonathan French (:jfrench)]

Save classification via keyboard shortcut (ctrl+shift+enter) should also be available soon, via bug 1030686.

Comment 5

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#327

Please see above PR for status and review.

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/f483c781eaa559a016c9d8f4dee0162967ab1da9
Bug 1074939 - Switch to a persistent pinboard Save UI

https://github.com/mozilla/treeherder-ui/commit/add185fd222e92fbea6beb3dceec26176eec7a5b
Merge pull request #327 from tojonmz/persistent-save-ui

Bug 1074939 - Switch to a persistent pinboard Save UI

Comment 7

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/528d18a52e6d7ee55a3e1c43e2465428c3a3bdef
Bug 1074939 - Switch to a persistent pinboard Save UI

https://github.com/mozilla/treeherder/commit/8af60e8126f6ed05241eda83b78530e4e35f0457
Merge pull request #327 from tojonmz/persistent-save-ui

Bug 1074939 - Switch to a persistent pinboard Save UI