Closed Bug 1107143 Opened 6 years ago Closed 5 years ago
Don't build event regions when not painting to the retained layer tree
MozReview Request: Bug 1107143 - Don't build event regions unless we're painting to the window. r?tnikkel
58 bytes, text/x-review-board-request
+++ This bug was initially created as a clone of Bug #1106537 +++ Spinoff from bug 1106537 comment 5. Right now we build event regions for all "PAINTING" mode displaylist builders but we probably don't need to do it unless the root reference frame for the displaylist builder is also the root document root frame. I don't know which scenarios this occurs in though. Probably it is this function that will need to change: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.h?rev=b291989a1656#344
We should probably just change it to IsPaintingToWindow() instead of just painting mode.
Summary: Don't build event regions when the root reference frame for a displaylistbuilder is not the root document root frame → Don't build event regions when not painting to the retained layer tree
Assignee: nobody → bugmail.mozilla
Review commit: https://reviewboard.mozilla.org/r/38537/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/38537/
Attachment #8727603 - Flags: review?(tnikkel)
Attachment #8727603 - Flags: review?(tnikkel) → review+
Comment on attachment 8727603 [details] MozReview Request: Bug 1107143 - Don't build event regions unless we're painting to the window. r?tnikkel https://reviewboard.mozilla.org/r/38537/#review35165 Wow, can't believe we didn't fix this sooner.
No noticeable talos impact from this change as far as I can tell. Wasn't really expecting any either, based on my local testing.
Given that, no real point in uplifting this.
You need to log in before you can comment on or make changes to this bug.