Closed Bug 1107143 Opened 6 years ago Closed 5 years ago

Don't build event regions when not painting to the retained layer tree

Categories

(Core :: Layout, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1106537 +++

Spinoff from bug 1106537 comment 5. Right now we build event regions for all "PAINTING" mode displaylist builders but we probably don't need to do it unless the root reference frame for the displaylist builder is also the root document root frame. I don't know which scenarios this occurs in though.

Probably it is this function that will need to change: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDisplayList.h?rev=b291989a1656#344
We should probably just change it to IsPaintingToWindow() instead of just painting mode.
Summary: Don't build event regions when the root reference frame for a displaylistbuilder is not the root document root frame → Don't build event regions when not painting to the retained layer tree
Blocks: 1106440
No longer blocks: 928833
Keywords: perf
No longer blocks: 1106440
Assignee: nobody → bugmail.mozilla
Attachment #8727603 - Flags: review?(tnikkel) → review+
Comment on attachment 8727603 [details]
MozReview Request: Bug 1107143 - Don't build event regions unless we're painting to the window. r?tnikkel

https://reviewboard.mozilla.org/r/38537/#review35165

Wow, can't believe we didn't fix this sooner.
No noticeable talos impact from this change as far as I can tell. Wasn't really expecting any either, based on my local testing.
Given that, no real point in uplifting this.
https://hg.mozilla.org/mozilla-central/rev/f4aec1239d76
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.