1107210 - Conversation Name doesn't update in the panel when changing it in the room preview

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

STR:

1) Create a new room
2) In the room preview, enter a name for the room, press enter or tab
3) Open the panel

Expected Results

- The panel displays the new name

Actual Results

- The panel displays the original name

Comment 1

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: Not correctly updating the UI in the new rooms code. Confusing to the user as to why a rename might not have happened.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Fixed room name update not correctly reflected in Loop panel.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8531714 [details] [diff] [review]
Fixed room name update not correctly reflected in Loop panel.

Is there some way we can/should test this?

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Fixed room name update not correctly reflected in Loop panel.

Added unit test.

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

https://hg.mozilla.org/integration/fx-team/rev/75fe9fbfe722

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75fe9fbfe722

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8532109 [details] [diff] [review]
Fixed room name update not correctly reflected in Loop panel.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Not correctly updating the UI in the new rooms code. Confusing to the user as to why a rename doesn't happen.

[Describe test coverage new/current, TBPL]: Includes test; plus manual test.  On m-c

[Risks and why]: Very simple, low-risk patch that affects only loop rooms

[String/UUID change made/needed]: none

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e8be247efd4c

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

After getting approvals and uplifting to Aurora, I noted that this bug actually depends on (fixes issues with) bug 1090173, which we did not ask for beta/35 approval for.  So I held off on uplifting this.

Removing checkin-needed, and probably we should mark this wontfix for 35

Comment 10

[Maire Reavy [:mreavy]]

>Removing checkin-needed, and probably we should mark this wontfix for 35
Actually, it would be more accurate to mark this "unaffected" for Fx35 since Bug 1090173 was not uplifted to Fx35.