1090173 - As a user, from the Panel, I should be able to rename a room

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Comment 1

[:shell escalante]

P1 to at least land the strings - if the bug is simple - let's get this in.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Postponed, we should rather focus on fx35+ stuff atm.

Comment 3

[Maire Reavy [:mreavy]]

The string to add is "Click to edit room name"

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Allow to rename a room from Loop panel.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8529778 [details] [diff] [review]
Allow to rename a room from Loop panel.

Review of attachment 8529778 [details] [diff] [review]:
-----------------------------------------------------------------

This is good, and I like it. One issue though:

- When I click on the form to edit, it highlights the existing name (that's fine).
- If I then click again (e.g. to put the cursor in somewhere), then it submits the form and opens the room.

It'd be nice if I am clicking on the input field for it to not submit/open the room - obviously outside that area would be a submit (though it'd also be nice if it didn't open the room when you're edit mode and click anywhere else on the panel).

::: browser/components/loop/ui/fake-mozLoop.js
@@ +53,5 @@
>    getLoopPref: function(pref) {
>      // Ensure UI for rooms is displayed in the showcase.
>      if (pref === "rooms.enabled") {
>        return true;
> +    } else if (pref === "gettingStarted.seen") {

I think you could just do:

if (pref === "rooms.enabled" ||
    pref === "gettingStarted.seen") {

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Allow to rename a room from Loop panel. Patch v2

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8529928 [details] [diff] [review]
Allow to rename a room from Loop panel. Patch v2

Review of attachment 8529928 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8

Comment 8

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

https://hg.mozilla.org/integration/fx-team/rev/ff920f2cebfb

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ff920f2cebfb

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8529928 [details] [diff] [review]
Allow to rename a room from Loop panel. Patch v2

Approval Request Comment
[Feature/regressing bug #]: rooms

[User impact if declined]: Can't rename a room from the room panel, only from within the room

[Describe test coverage new/current, TBPL]: Includes tests, on central

[Risks and why]: Low risk as functionality already existed, and still exists.  Not uplifting to Beta since the strings required landed in 36.  Landed on fxteam before aurora uplift but didn't merge to central in time.

[String/UUID change made/needed]: none (already landed/uplifted in patch 1).

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f8c5916024a7