1107484 - Recommended tab shown after turning off in settings

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Madalin Cotetiu]

Steps to reproduce:
1. Open mp-dev homepage and log in: https://marketplace-dev.allizom.org
2. Click on the gear icon to open account settings page: https://marketplace-dev.allizom.org/settings
3. Check the "Yes, show me recommendations" box.
4. Click on Save changes button.
5. Refresh the page.

Expected results:
After steps 4 and 5 the Recommendation tab is displayed.

Actual results:
After step 4 the Recommendation tab is displayed, after step 5 (refreshing the page) Recommendation tab is no longer displayed. 

The issue above occurs in marketplace-dev where recommendation flag is on. 
Screencast for the issue on -dev: http://screencast.com/t/u5uapAt9

Something similar is happening in stage where the flag is off.

The steps for marketplace-stage are:
1. Open mp-stage homepage and log in: https://marketplace.allizom.org
2. Click on the gear icon to open account settings page: https://marketplace.allizom.org/settings
3. Check the "Yes, show me recommendations" box.
4. Click on Save changes button.
5. Refresh the page.

Expected results:
After step 4 the recommendation tab is not displayed. (because the recommendation flag is off on stage) After refreshing the page recommendation tab is still not displayed.

Actual results:
After step 4 the recommendation tab is displayed. After refreshing the page recommendation tab is no longer displayed.

Screencast for the issue in stage: http://screencast.com/t/32tpiknhOfxf

Comment 1

[Rob Hudson [:robhudson]]

We should fix this before we enable recommendations in production.

My hunch is that we are storing the user information from the initial API call and not refreshing it after the setting change, so a page refresh will just use the local cached setting which is incorrect. If that's the case I should update it to save the setting in localStorage upon change so it persists.

Comment 2

[Rob Hudson [:robhudson]]

PR: https://github.com/mozilla/fireplace/pull/835

Comment 3

[Victor Carciu]

Please note that this is reproducible on Stage, with following steps:

1.In settings disable recommendations(observe that the link is not displayed anymore)
2.Refresh the page

Expected:
Recommendations not displayed

Actual results:
Recommendations are displayed

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/fireplace/commit/6e6d7ec

Comment 5

[Madalin Cotetiu]

Verified as fixed in FF37(Win7) in marketplace-dev.allizom.org
Screencast for this issue: http://screencast.com/t/noT1NpoI