1107509 - New search bar improvements

Status: RESOLVED DUPLICATE of bug 1110767

(Firefox :: Search, defect)

Description

[FM33]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141127111021

Steps to reproduce:

Here are a few suggestions of improvements for new search bar, to make the ""Manage Search Engines" button" add-on unnecessary and the functionalities better integrated.

 - When using the down arrow to select an engine, the name of the highlighted engine should appear in the menu.

 - Use Ctrl+clic (or ctrl+enter) on an engine should run the search AND set the selected engine as default. This is useful when making several searches on the same engine.

 - Add an entry in the menu to open the "manage engines" dialog to allow setting keyword, ordering and removing engines.

Comment 1

[:Gijs (out for now; he/him)]

(In reply to [e-mail] from comment #0)
>  - When using the down arrow to select an engine, the name of the
> highlighted engine should appear in the menu.

I think this makes sense.

>  - Use Ctrl+clic (or ctrl+enter) on an engine should run the search AND set
> the selected engine as default. This is useful when making several searches
> on the same engine.

ctrl-click/enter is 'taken' for opening the search in a new tab.

>  - Add an entry in the menu to open the "manage engines" dialog to allow
> setting keyword, ordering and removing engines.

That's what the bottom item does? On current nightly/beta, you can edit keywords and remove engines, as well as reorder them by dragging.

Comment 2

[Florian Quèze [:florian]]

(In reply to [e-mail] from comment #0)

>  - When using the down arrow to select an engine, the name of the
> highlighted engine should appear in the menu.

This is covered by bug 1110767.

>  - Use Ctrl+clic (or ctrl+enter) on an engine should run the search AND set
> the selected engine as default. This is useful when making several searches
> on the same engine.

Like Gijs said, this opens the search in a new tab (since bug 1106101).

>  - Add an entry in the menu to open the "manage engines" dialog to allow
> setting keyword, ordering and removing engines.

I expect to remove the manage engines dialog completely in Firefox 38, now that all its features are integrated directly in the search preference pane (since bug 1106559).

Comment 3

[FM33]

(In reply to :Gijs Kruitbosch from comment #1)
> ctrl-click/enter is 'taken' for opening the search in a new tab.

Maybe another one then. What about shift ? Seems not having any use for this case in Nightly.
Note : in the current nightly, Ctrl-click opens a new tab, but not ctrl-enter.

> That's what the bottom item does? On current nightly/beta, you can edit
> keywords and remove engines, as well as reorder them by dragging.

Yes, it works ! This is a very recent update. Wasn't there previous time I updated.

Comment 4

[Florian Quèze [:florian]]

(In reply to [e-mail] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #1)
> > ctrl-click/enter is 'taken' for opening the search in a new tab.
> 
> Maybe another one then. What about shift ? Seems not having any use for this
> case in Nightly.
> Note : in the current nightly, Ctrl-click opens a new tab, but not
> ctrl-enter.

I think this would leave us with users who triggered it by accident and don't understand how come their default search engine was changed. So I would prefer this specific behavior to be done with an add-on.

I'm hoping bug 1110678 (ctrl+up/down to change default engine) will help for the use case you mentioned though :).