Closed
Bug 1107536
Opened 10 years ago
Closed 10 years ago
[rooms] There should always be a spot in the room reserved for the room owner
Categories
(Hello (Loop) :: Server, defect)
Hello (Loop)
Server
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: alexis+bugs)
References
Details
(Whiteboard: [loop-server 0.14.1])
Attachments
(2 files, 1 obsolete file)
|
7.51 KB,
patch
|
alexis+bugs
:
review+
standard8
:
feedback+
|
Details | Diff | Splinter Review |
|
1.67 KB,
patch
|
alexis+bugs
:
review+
|
Details | Diff | Splinter Review |
In the current implementation of rooms with only 2 people, if I pass a room url to two other people, and they both click it, then I can't get into the room that I created. This needs changing - the room owner should always have a reserved spot for accessing the room.
|
||
Comment 1•10 years ago
|
||
After doing some heavy testing yesterday, I realize that this bug is really important to fix ASAP. Tarek -- How soon can you, Remy or Alexis fix this? Thanks.
Flags: needinfo?(tarek)
|
Assignee | |
Comment 2•10 years ago
|
||
Is this okay if this goes in the 0.15.0 release (should be out mid-next week)? I'll write a patch for it hopefully today or tomorrow, but it needs to get trough stage, verification and then stage deploy.
Flags: needinfo?(tarek)
|
|
Assignee | |
Comment 3•10 years ago
|
||
This adds a "canJoinRoom" function, which will return if it's possible for the user to join the room. When doing the count, it is checking if the room owner is currently connected or not.
Attachment #8533705 -
Flags: review?(tarek)
Attachment #8533705 -
Flags: feedback?(standard8)
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [loop-server 0.14.1]
|
|
Assignee | |
Comment 4•10 years ago
|
||
Standard8, I deployed the current branch fix at https://loop-dev.stage.mozaws.net/, let met see if that's okay for you.
Flags: needinfo?(standard8)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8533705 -
Attachment is obsolete: true
Attachment #8533705 -
Flags: review?(tarek)
Attachment #8533705 -
Flags: feedback?(standard8)
Attachment #8533712 -
Flags: review?(tarek)
Attachment #8533712 -
Flags: feedback?(standard8)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → alexis+bugs
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8533783 -
Flags: review?(tarek)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8533712 [details] [diff] [review] Same as the previous patch, but with some lint fixes in addition. https://github.com/mozilla-services/loop-server/commit/4dd5f774773b7f7462dcc2bbc7eeee8d1f13afae
Attachment #8533712 -
Flags: review?(tarek) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
Comment on attachment 8533783 [details] [diff] [review] Fix how the client max size is handled. https://github.com/mozilla-services/loop-server/commit/4dd5f774773b7f7462dcc2bbc7eeee8d1f13afae
Attachment #8533783 -
Flags: review?(tarek) → review+
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 9•10 years ago
|
||
Comment on attachment 8533712 [details] [diff] [review] Same as the previous patch, but with some lint fixes in addition. From a quick test, this looks good.
Flags: needinfo?(standard8)
Attachment #8533712 -
Flags: feedback?(standard8) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•