1114374 - Unable to join room as link-clicker if the creator is in the room when logged in (regression)

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

+++ This bug was initially created as a clone of Bug #1111579 +++

Regression (recent; likely due to the server bug I cloned from):

If I create a room while logged in (aurora or nightly; will test beta later) I get added to the room as usual.  If the link-clicker tries to join, they're told there are already 2 people in the room.  If the creator leaves the room, the clicker can join and then the creator can join.

If I'm not logged in, things work normally.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

NI in case mark has any insights

Comment 2

[Mark Banner (:standard8)]

I believe this is actually a regression from bug 1107536.

Comment 3

[Alexis Metaireau (:alexis)]

I'm on this, trying to find what the problem is. Mak believes (and I agree) that this is caused by bug 1107536.
I'm currently on a fix for this and will try to hotfix.

Comment 4

[Alexis Metaireau (:alexis)]

Attachment: Fix how the room owner is counted.

We want to always let him a spot available, but the way we were counting him
wasn't actually counting properly when it was a logged in account.

Comment 5

[Rémy Hubscher (:natim)]

Comment on attachment 8540196 [details] [diff] [review]
Fix how the room owner is counted.

Review of attachment 8540196 [details] [diff] [review]:
-----------------------------------------------------------------

::: test/rooms_test.js
@@ +994,5 @@
>              });
>            });
>          });
>  
> +        it("an user should be able to join after the room owner", function(done){

"a user" even if user starts with a u we don't do the liaison because of the sound of the u.

Note: This is a nitpick to try the bugzilla review tool: http://forum.wordreference.com/showthread.php?t=480322&p=2743756#post2743756

@@ +1266,5 @@
>              createRoom(hawkCredentials).end(function(err, res) {
>                 if (err) throw err;
>                 var roomToken = res.body.roomToken;
>                 // Alexis joins
> +               joinRoom(hawkCredentials, roomToken).end(function(err) {

This changes a bit the test because it means the owner have to be in the room. But well why not :)

Comment 6

[Alexis Metaireau (:alexis)]

Yes, we need to change the test here, because we need to always retain a spot available for the room owner, and we have no way to know who the room owner is when using session tokens.

https://github.com/mozilla-services/loop-server/commit/d5b98be9e62f0fc4f626c85c31766ca9329c01cb

Comment 7

[Alexis Metaireau (:alexis)]

This is now deployed to prod thanks to Bob, Dean and Richard.