Closed
Bug 1107698
Opened 9 years ago
Closed 9 years ago
Fix setAlpha in ResizablePathDrawable
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox36 fixed, firefox37 fixed)
RESOLVED
FIXED
Firefox 37
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(2 files, 1 obsolete file)
2.45 KB,
patch
|
mcomella
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.08 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
setAlpha(0) will prevent drawing but other values will be full opacity. This is because setAlpha just overrides the color's alpha value, but we reset the color each time we draw.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8532254 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8532254 [details] [diff] [review] setAlpha after setColor in ResizablePathDrawable Review of attachment 8532254 [details] [diff] [review]: ----------------------------------------------------------------- Yep. ::: mobile/android/base/widget/ResizablePathDrawable.java @@ +58,5 @@ > + // setAlpha overrides the alpha value in set color. Since we just set the color, > + // the alpha value is reset: override the alpha value with the old value. > + // > + // Note: We *should* be able to setAlpha on the Shape, rather than the Paint, but > + // this the opacity doesn't change - dunno why but probably not worth the time. nit: remove the 'the'
Attachment #8532254 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Updated for nits.
Assignee | ||
Updated•9 years ago
|
Attachment #8532254 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Attachment #8532576 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/82c71c7d725c
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/82c71c7d725c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8532750 -
Flags: review?(bnicholson)
Updated•9 years ago
|
Attachment #8532750 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 7•9 years ago
|
||
re comment 6: I forgot to update the alpha when updating the color.
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/07b9fe542495
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8532576 [details] [diff] [review] setAlpha after setColor in ResizablePathDrawable Applies to parts 1 and 2. Approval Request Comment [Feature/regressing bug #]: New tablet release [User impact if declined]: We won't be able to uplift bug 1085771, which means lightweight themes will be unpolished in the new tablet release [Describe test coverage new/current, TBPL]: None [Risks and why]: We could cause issues with the alpha channels in the tab strip which, in the worst case means the tabs disappear, but generally means we'll look less polished. [String/UUID change made/needed]: None
Attachment #8532576 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8532576 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•