1108374 - Make tip install on Landfill use Perl 5.10

Status: RESOLVED FIXED

(Bugzilla :: bugzilla.org, defect)

Description

[Gervase Markham [:gerv]]

Bugzilla trunk requires 5.10, but the system Perl on Landfill is 5.8. There were some local customizations making it use a 5.10 install which is also on the box, but these were lost in the move from bzr to git.

We should either restore those customizations, or upgrade the system Perl.

Gerv

Comment 1

[Teemu Mannermaa (:wicked)]

(In reply to Gervase Markham [:gerv] from comment #0)
> or upgrade the system Perl.

No, this is not something you'd want to do. Also, this will be taken care of once we get the migration to a new CentOS 6 based one done.

I'll give you a hint of the "local customizations", please read this FAQ entry https://wiki.mozilla.org/Bugzilla:FAQ#My_perl_is_located_at_.2Fusr.2Flocal.2Fbin.2Fperl_and_not_.2Fusr.2Fbin.2Fperl._Is_there_an_easy_to_change_that_in_all_the_files_that_have_this_hard-coded.3F

You will need to use install-module.pl to install almost all required/optional modules, though.

Comment 2

[Gervase Markham [:gerv]]

We don't need to reinstall all the modules, because I think when dkl made this change, he saved the old install, and so it'll have a lib/ directory we can just pinch.

I'm sure whoever fixes this can run the magic command to switch to the Perl 5.10, but it might help if you gave us a clue as to where it was installed? :-)

Gerv

Comment 3

[David Lawrence [:dkl]]

I have fixed this (again). I had this working on friday but somehow the git checkout got messed up. It was no longer tracking the master branch and was show (no branch) when doing 'git branch'. Doing 'git checkout master' would not work as it that a merge had failed and 'error: you need to resolve your current index first'. So I did 'git reset --merge' and afterwards I was able to 'git checkout master'. Once that worked I got back to my previous fixes from friday and recomfirmed my cron job changes were working again. I will make not to check it again tomorrow to make sure it is still working.

FWIW, the changes I did on friday were to replace /usr/bin/perl with /usr/bin/perl5.10.1 in all *.cgi and *.pl files. There was also a different issue that we had to work around with using Moo with perl5.10.1 and strictures. (Will file a bug for this when I get to the office. I added to Bugzilla::Constants:

BEGIN {
    $ENV{PERL_STRICTURES_EXTRA} = 0;
}

which fixed the problem of errors when encountering 'state' and 'say'.

dkl