1108425 - :(-moz-)dir(rtl) doesn't match <textarea dir="auto"> with right-to-left text

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[sukolsak]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141125180439

Steps to reproduce:

See the following webpage: http://jsfiddle.net/b4rhxrc2/


Actual results:

The textarea doesn't have a green background.


Expected results:

The textarea should have a green background.

According to https://html.spec.whatwg.org/multipage/dom.html#the-directionality, the directionality of the textarea with a right-to-left character at the beginning should be 'rtl'. Therefore, it should match :(-moz-)dir(rtl).

Comment 1

[Simon Montagu :smontagu]

We discussed this issue in bug 562169 comment 67 and following. From bug 562169 comment 70 it looks as if we do need to fix it

Comment 2

[Boris Zbarsky [:bzbarsky]]

This needs an owner...

Comment 3

[Vincent Hilla [:vhilla]]

HTMLTextAreaElement is not updating its directionality the same way HTMLInputElement does via SetDirectionFromValue. Thus, neither the :dir selector nor the dirname attribute are working correctly with dir=auto.

Comment 4

[Vincent Hilla [:vhilla]]

Attachment: Bug 1108425 - Fix dir=auto for textarea with rtl text. r=smaug

I copy-pasted all SetDirectionFromValue-related parts from HTMLInputElement to HTMLTextAreaElement

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D176999	Bug 1108425 - Fix dir=auto for textarea with rtl text. r=bzbarsky	vhilla	bzbarsky: Inactive

:vhilla, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f394b22e31d
Fix dir=auto for textarea with rtl text. r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40032 for changes under testing/web-platform/tests

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on bidi/726420-1.html

• backout: https://hg.mozilla.org/integration/autoland/rev/4b86cd377e1d9c271d63e81d6ef581cbf06643b5
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=YA9qgMI9TyWjFSkuVbmTIQ.0&revision=2f394b22e31de842bc297b08a230f6d298768d4c
• tier 1 failure here: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=B5GYlWP0TeOUgydVzLrEbQ.0&revision=2814e09f635a0c47aadae8c3cb5ac25f11fc2559&searchStr=android%2C7.0%2Cx86-64%2Cwebrender%2Copt%2Creftests%2Cwithout%2Cfission%2Cenabled%2Ctest-android-em-7.0-x86_64-qr%2Fopt-geckoview-reftest-nofis%2Cr1
• failure log: https://treeherder.mozilla.org/logviewer?job_id=415971558&repo=autoland&lineNumber=10514

Comment 9

[Natalia Csoregi [:nataliaCs]]

Also failing on /html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs.html

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Vincent Hilla [:vhilla]]

I wanted to delete bidi/726420-1.html but missed to update reftest.list.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6638f5e6d9f
Fix dir=auto for textarea with rtl text. r=smaug

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e6638f5e6d9f

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot