675943 - Need support for dirname attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aharon (Vladimir) Lanin]

Attachment: dirname.html

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.122 Safari/534.30




Expected results:

HTML5 added a new attribute for <input> and <textarea>, dirname (http://dev.w3.org/html5/spec/Overview.html#the-dirname-attribute):

"A form control dirname attribute on a form control element enables the submission of the directionality of the element, and gives the name of the field that contains this value during form submission. If such an attribute is specified, its value must not be the empty string."

Please note that the directionality is always either "ltr" or "rtl". It is never "auto" or "" or null.

Example:

<form action="addcomment.cgi" method=post>
 <p><label>Comment: <input type=text name="comment" dirname="comment.dir" required></label></p>
 <p><button name="mode" type=submit value="add">Post Comment</button></p>
</form>
When the user submits the form, the user agent includes three fields, one called "comment", one called "comment.dir", and one called "mode"; so if the user types "Hello", the submission body might be something like:

comment=Hello&comment.dir=ltr&mode=add
If the user manually switches to a right-to-left writing direction and enters "مرحبًا", the submission body might be something like:

comment=%D9%85%D8%B1%D8%AD%D8%A8%D9%8B%D8%A7&comment.dir=rtl&mode=add

Comment 2

[Sebastian Zartner [:sebo]]

The URL of the specification changed and is now available here:

http://www.w3.org/TR/html5/forms.html#submitting-element-directionality:-the-dirname-attribute (latest HTML 5 Working Draft)
http://www.w3.org/html/wg/drafts/html/master/forms.html#submitting-element-directionality:-the-dirname-attribute (latest HTML 5.1 Nightly)

One of these URLs should be added to the 'URL' field. (I don't have the rights to do that.)

Sebastian

Comment 3

[Matthew N. [:MattN]]

WHATWG specs are generally preferred IIUC.

Comment 4

[Sebastian Zartner [:sebo]]

Fine for me.

So now this just needs someone to implement.

Sebastian

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

These .dirName wpt tests fail due to the lack of the support.

Comment 7

[Vincent Hilla [:vhilla]]

Attachment: Bug 675943 - Part 1: Implement dirname attr for input elements within forms. r=edgar

Comment 8

[Vincent Hilla [:vhilla]]

Clarification around dirname on input elements just merged to whatwg, see issue 9206

Comment 9

[Vincent Hilla [:vhilla]]

Attachment: Bug 675943 - Part 2: Implement dirname attr for textarea elements within forms. r=edgar

Comment 10

[Vincent Hilla [:vhilla]]

Attachment: Bug 675943 - Part 3: Clean up after implementing dirname. r=edgar

Depends on D178164

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33fabcece85d
Part 1: Implement dirname attr for input elements within forms. r=edgar
https://hg.mozilla.org/integration/autoland/rev/8f514549a81c
Part 2: Implement dirname attr for textarea elements within forms. r=edgar
https://hg.mozilla.org/integration/autoland/rev/56d084bfc8b8
Part 3: Clean up after implementing dirname. r=edgar

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hey Vincent, once this lands and be stuck in m-c, can you nominate this for release note? Simply change the Status of the tracking flag relnote-firefox from --- to ?, then fill in the fields on the comment.

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40190 for changes under testing/web-platform/tests

Comment 14

[Cosmin Sabou [:CosminS]]

Backed out for causing wpt unexpected passes.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=BT7I9QzVQR2gnshybYc6Bg.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=1db51625512e546534a6a7352ff4ff3b9c48d713&searchStr=web%2Cplatform

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=416860308&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=416861655&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/21e8996740c5b77f29d3e7e1630f68dad8bc0dec

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 16

[Vincent Hilla [:vhilla]]

Missed some unexpected passes, did further testing and hopefully catched all.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e52989251ae
Part 1: Implement dirname attr for input elements within forms. r=edgar
https://hg.mozilla.org/integration/autoland/rev/9eba8dccc395
Part 2: Implement dirname attr for textarea elements within forms. r=edgar
https://hg.mozilla.org/integration/autoland/rev/84a06f46030f
Part 3: Clean up after implementing dirname. r=edgar

Comment 18

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2e52989251ae
https://hg.mozilla.org/mozilla-central/rev/9eba8dccc395
https://hg.mozilla.org/mozilla-central/rev/84a06f46030f

Comment 19

[Vincent Hilla [:vhilla]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Text directionality can change through multiple ways. If a server wants to reliably display the submitted text correctly, it has to know about the text directionality as it was in the users editor.
[Affects Firefox for Android]: Yes
[Suggested wording]: Added support for the dirname attribute to pass text directionality information about input and textarea elements to the server.
[Links (documentation, blog post, etc)]:
https://www.w3.org/International/questions/qa-html-dir#reportingdirection
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#dirname

Comment 20

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 21

[Dianna Smith [:diannaS]]

Added to 116.0a1 nightly notes https://www.mozilla.org/en-US/firefox/116.0a1/releasenotes/

Comment 22

[Vincent Hilla [:vhilla]]

Updated browser-compat-data: 20109

Comment 23

[Brian Thomas Smith [bsmth]]

MDN documentation changes for this can be tracked on the following GitHub issue: https://github.com/mdn/content/issues/27760

(Thank you for the BCD additions)

Comment 24

[Brian Thomas Smith [bsmth]]

Basic info with release note added to MDN, setting as dev-doc-complete for now. Follow-up improvements incoming as described in the linked GitHub issue.