1108554 - Addon validation timeouts on lightning linux beta

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Mathieu Agopian [:magopian]]

Seems like the increased size of the latest lightning linux beta (4.4Mb) is enough to go past the addon validation timeout.

The message displayed when uploading the addon is the following:

"your addon failed validation with 1 error: Validation timed out."

This doesn't happen each time, sometimes, retrying will get through.

Bug created on behalf of :Fallen

Comment 1

[David Larlet [:davidbgk]]

Let's bump the timeout for now.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Note that bug 1108343 is for a similar problem, so there might be something else going on.

Comment 3

[Tom Mutdosch]

Attachment: reminderfox_2.1.5.1_release_20141205_2217.xpi

ReminderFox 2.1.5.1 addon exhibiting AMO Update Validation timeout.

Comment 4

[Tom Mutdosch]

ReminderFox is another addon that was experiencing timeouts when I tried to upload between December 6-8.  I keep getting:
the validation is failing due to:

"Validation timed out.  Error: The validation process took too long to complete. Contact an addons.mozilla.org editor for more information.
Validation timeout after 90 seconds"
ReminderFox is quite large (> 1MB), but the validation never timed out before. Perhaps there's additional validation processing that takes longer now.

See attached version of the addon.

Comment 5

[David Larlet [:davidbgk]]

https://github.com/mozilla/olympia/commit/eb5001adfc4042a34663b1c84c6c3f578021aade

We need to improve the performances of the amo-validator but that's a huge work so it'll not be for that push. Let's see if increasing the validation timeout is enough for now.

Comment 6

[Mark Striemer [:mstriemer]]

We had a similar bug on zamboni that was being caused by using django's transaction middleware. It was fixed in bug 1108462. I did a grep of olympia when I saw that and didn't see the transaction middleware but just commenting in case the timeout bump doesn't fix this.

Comment 7

[Victor Carciu]

Verified with the attached addon and the timeout issue is not reproducible anymore : http://screencast.com/t/7ehNps3aX1n

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: lightning-linux.xpi

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

While it might work for 1.23mb, it still does not work for the originally reported addon, which is much larger. It is still an issue for me. Please set the timeout accordingly, I really want to get this addon out asap because 3.6b1 and b2 is totally broken for Seamonkey.

Comment 10

[Mathieu Agopian [:magopian]]

We have planned a push to production of the fix for today... if everything goes as expected, you should be able to test again soon.

Comment 11

[Mathieu Agopian [:magopian]]

The push is done, so feel free to try again, and please let us know if it fixed now.

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Great, that seemed to have worked! I've managed to upload all 3.6b3 packages. Thank you so much :)

Comment 13

[Mathieu Agopian [:magopian]]

Happy that it worked, thanks David again for fixing that!