1108928 - Add front end for displaying automation data for web audio

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: v1

This is pretty good -- creating follow up bugs for it, and will probably hold back releasing this until 38.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1ca7cec590c4

Comment 2

[Victor Porof [:vporof][:vp]]

Damn it jordan.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Mostly pulling out the properties view into a child of a new inspector view, and the new automation view, so just 2 tabbed views.. let me know if you have any questions, automation stuff is weird.

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8544942 [details] [diff] [review]
v1

Review of attachment 8544942 [details] [diff] [review]:
-----------------------------------------------------------------

Lotsa code, can't really find anything wrong with it.

::: browser/devtools/webaudioeditor/views/automation.js
@@ +147,5 @@
> +   * Called when the marker details view is resized.
> +   */
> +  _onResize: function () {
> +    this.graph.refresh();
> +    //this.render();

Leftover comment?

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1108928-ui-automation.patch

Fixed test failure, rebased:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=33e2e088b462

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/bbfbd3bf26aa

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bbfbd3bf26aa