Closed
Bug 1117971
Opened 10 years ago
Closed 10 years ago
Make avg/min/max displays on the line graph optional
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
|
13.52 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
Used for the web audio editor's automation view, the average, min and max tooltip, gutter and lines should be optional.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jsantell
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8544208 -
Flags: review?(vporof)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8544208 [details] [diff] [review]
1117971-linegraph-options.patch
Review of attachment 8544208 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/shared/widgets/Graphs.jsm
@@ +1444,5 @@
> + this._maxTooltip.hidden = this._showMax === false || !totalTicks || distanceMinMax < LINE_GRAPH_MIN_MAX_TOOLTIP_DISTANCE;
> + this._avgTooltip.hidden = this._showAvg === false || !totalTicks;
> + this._minTooltip.hidden = this._showMin === false || !totalTicks;
> + this._gutter.hidden = (this._showMin === false && this._showMax === false) || !totalTicks || !this.withTooltipArrows;
> +
Nit: whitespace.
Attachment #8544208 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8544208 -
Attachment is obsolete: true
Attachment #8544279 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•