Improve the speed of build_stage

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rickychien, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We should figure out whether build_stage is a necessary step for build process or speed up in another way.
It takes between 1 and 6s to rebuild an app with `APP=foo make`.
It is too much. It should be faster, especially in developer mode, without all optimization (minification, compression, multilocale, ...).
Created attachment 8556484 [details] [review]
Pull request 27780 - tweak multilocale optimize step

I was able to save 1s of build time with this naive optimization in multilocale optimize step...
But I think we could win even more with better data structure or some better algorithm to do this!

So the system app now takes 2s to build instead of 3s.
Attachment #8556484 - Flags: review?(stas)
Also I looked at why clock is taking 2s to build, most of this time is spent in r.js and it is not really clear what we do here and what precise code is taking almost a second to process this simple app.
Comment on attachment 8556484 [details] [review]
Pull request 27780 - tweak multilocale optimize step

For-loop caching ftw!  Thanks :)  r=me with a suggestion left on github.
Attachment #8556484 - Flags: review?(stas) → review+
master:
https://github.com/mozilla-b2g/gaia/commit/2130a414247340384b5aa9a88918c74b074b7fa1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.