Closed Bug 1108990 Opened 9 years ago Closed 9 years ago

Refactor testAdons_changeTheme from multiple files into a single file

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox36 fixed, firefox37 fixed)

RESOLVED FIXED
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: daniela.domnici, Assigned: daniela.domnici)

References

Details

(Whiteboard: [sprint])

Attachments

(3 files, 2 obsolete files)

Combined three tests from testAddons_changeTheme into one test.
Assignee: nobody → daniela.domnici
Attached patch patch_V1 (obsolete) — Splinter Review
Combined three tests from testAddons_changeTheme into one test.
Attachment #8533642 - Flags: review?(mihaela.velimiroviciu)
Attachment #8533642 - Flags: review?(andreea.matei)
Comment on attachment 8533642 [details] [diff] [review]
patch_V1

Review of attachment 8533642 [details] [diff] [review]:
-----------------------------------------------------------------

The patch didn't apply.
Please also update the commit message and remove [include:testAddons_changeTheme/manifest.ini] from firefox/tests/functional/restartTests/manifest.ini

::: firefox/tests/functional/testAddons/testChangeTheme.js
@@ +75,4 @@
>    controller.waitForPageLoad();
>  
> +  var installLink = findElement.Selector(controller.tabs.activeTab,
> +                                         "#addon");

This can stay on the previous line
Attachment #8533642 - Flags: review?(mihaela.velimiroviciu)
Attachment #8533642 - Flags: review?(andreea.matei)
Attachment #8533642 - Flags: review-
Attached patch patch_V2 (obsolete) — Splinter Review
Updated patch for testChangeTheme
Attachment #8533642 - Attachment is obsolete: true
Attachment #8534851 - Flags: review?(mihaela.velimiroviciu)
Attachment #8534851 - Flags: review?(andreea.matei)
Comment on attachment 8534851 [details] [diff] [review]
patch_V2

Review of attachment 8534851 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Attachment #8534851 - Flags: review?(mihaela.velimiroviciu)
Attachment #8534851 - Flags: review+
Attachment #8534851 - Flags: checkin?(andreea.matei)
Comment on attachment 8534851 [details] [diff] [review]
patch_V2

Review of attachment 8534851 [details] [diff] [review]:
-----------------------------------------------------------------

Just a small update needed before we land this.

::: firefox/tests/functional/testAddons/testChangeTheme.js
@@ +142,5 @@
> +
> +  assert.equal(defaultTheme.getNode().getAttribute("active"), "true");
> +}
> +
> +

Too many blank lines :)
Attachment #8534851 - Flags: review?(andreea.matei)
Attachment #8534851 - Flags: review+
Attachment #8534851 - Flags: checkin?(andreea.matei)
Attached patch patch_V3Splinter Review
updated patch :)
Attachment #8535563 - Flags: checkin?(andreea.matei)
Comment on attachment 8535563 [details] [diff] [review]
patch_V3

Review of attachment 8535563 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/e0240c4920cc (default)
Attachment #8535563 - Flags: checkin?(andreea.matei) → checkin+
Attachment #8534851 - Attachment is obsolete: true
I`ve created a new patch for aurora branch.
Attachment #8537812 - Flags: review?(mihaela.velimiroviciu)
Attachment #8537812 - Flags: review?(andreea.matei)
Attachment #8537812 - Flags: review?(mihaela.velimiroviciu)
Attachment #8537812 - Flags: review?(andreea.matei)
Attachment #8537812 - Flags: review+
I`ve created a new patch for beta branch
Attachment #8539119 - Flags: review?(mihaela.velimiroviciu)
Attachment #8539119 - Flags: review?(andreea.matei)
Attachment #8539119 - Flags: review?(mihaela.velimiroviciu)
Attachment #8539119 - Flags: review?(andreea.matei)
We decided to let this ride the trains further on. Thanks Daniela!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: