1108990 - Refactor testAdons_changeTheme from multiple files into a single file

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Domnici]

Combined three tests from testAddons_changeTheme into one test.

Comment 1

[Daniela Domnici]

Attachment: patch_V1

Combined three tests from testAddons_changeTheme into one test.

Comment 2

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8533642 [details] [diff] [review]
patch_V1

Review of attachment 8533642 [details] [diff] [review]:
-----------------------------------------------------------------

The patch didn't apply.
Please also update the commit message and remove [include:testAddons_changeTheme/manifest.ini] from firefox/tests/functional/restartTests/manifest.ini

::: firefox/tests/functional/testAddons/testChangeTheme.js
@@ +75,4 @@
>    controller.waitForPageLoad();
>  
> +  var installLink = findElement.Selector(controller.tabs.activeTab,
> +                                         "#addon");

This can stay on the previous line

Comment 3

[Daniela Domnici]

Attachment: patch_V2

Updated patch for testChangeTheme

Comment 4

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8534851 [details] [diff] [review]
patch_V2

Review of attachment 8534851 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8534851 [details] [diff] [review]
patch_V2

Review of attachment 8534851 [details] [diff] [review]:
-----------------------------------------------------------------

Just a small update needed before we land this.

::: firefox/tests/functional/testAddons/testChangeTheme.js
@@ +142,5 @@
> +
> +  assert.equal(defaultTheme.getNode().getAttribute("active"), "true");
> +}
> +
> +

Too many blank lines :)

Comment 6

[Daniela Domnici]

Attachment: patch_V3

updated patch :)

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8535563 [details] [diff] [review]
patch_V3

Review of attachment 8535563 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/e0240c4920cc (default)

Comment 8

[Daniela Domnici]

Attachment: Aurora_changeTheme_V1

I`ve created a new patch for aurora branch.

Comment 9

[Andreea Matei [:AndreeaMatei]]

http://hg.mozilla.org/qa/mozmill-tests/rev/d8a2ca985d0e (aurora)

Comment 10

[Daniela Domnici]

Attachment: Beta _changeTheme_V1

I`ve created a new patch for beta branch

Comment 11

[Andreea Matei [:AndreeaMatei]]

We decided to let this ride the trains further on. Thanks Daniela!