1036294 - Refactor restart tests from multiple files into a single file

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[Andrei Eftimie]

We're having multiple problems with restart tests.
One particular problem is bug 972912 where mozmill apparently doesn't run (or doesn't report) running a test at all. The problem with a suite of restart tests is that if a test in the middle of a run is missing, subsequent tests will fail.

We should move all restart tests which are now split across different files into a single file.

Comment 1

[Daniela Domnici]

Attachment: installTheme_V1

I`ve created installTheme patch.

Comment 2

[Daniela Domnici]

Attachment: uninstallTheme_V1

I`ve created uninstallTheme patch.

Comment 3

[Daniela Domnici]

Attachment: changeTheme_V1

I`ve created changeTheme patch.

Comment 4

[Daniela Domnici]

Attachment: installMultpleExtensions_V1

I`ve created installMultipleExtensions patch.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Daniela, this is more a tracking bug. Please file separate bugs for any restart test you are working on, and make those blocking this bug. Otherwise this bug will become a mess in terms of reviews and such. Thanks.

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8533587 [details] [diff] [review]
installMultpleExtensions_V1

This will be reviewed in bug 1108994, so I'm clearing the review flags here

Comment 7

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8533168 [details] [diff] [review]
changeTheme_V1

Review of attachment 8533168 [details] [diff] [review]:
-----------------------------------------------------------------

This is tracked in bug 1108990, so I'm removing the review requests from here

Comment 8

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8533150 [details] [diff] [review]
installTheme_V1

Review of attachment 8533150 [details] [diff] [review]:
-----------------------------------------------------------------

Removing the review request flag since this is handled in bug 1108992

Comment 9

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8533164 [details] [diff] [review]
uninstallTheme_V1

Review of attachment 8533164 [details] [diff] [review]:
-----------------------------------------------------------------

Same here.

Daniela, given that in all bugs you will touch the manifest, the patches won't apply anymore, when one lands. So I propose that you do them in an order and include the manifest change from the previous ones. We will review them in the order in which you attach them.

Comment 10

[Andreea Matei [:AndreeaMatei]]

I think we can close this one now, all tests have been refactored. I will update bug 904610 to see what's left there as affected, since it reproduced more often before, maybe we need backport for that bug.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We still have restart tests in:

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/functional/restartTests
http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/remote/restartTests

I wonder if we should convert them or not. Maybe not, so you can spend time on more important bugs and then Marionette soon.