1108993 - Refactor testAdons_uninstallTheme from multiple files into a single file

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Domnici]

Combined three tests from testAddons_uninstallTheme into one test.

Comment 1

[Daniela Domnici]

Attachment: patch_V1

Comment 2

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8533646 [details] [diff] [review]
patch_V1

Review of attachment 8533646 [details] [diff] [review]:
-----------------------------------------------------------------

Update the commit message.
You should also remove [include:testAddons_uninstallTheme/manifest.ini] from firefox/tests/functional/restartTests/manifest.ini

::: firefox/tests/functional/testAddons/testUninstallTheme.js
@@ +64,5 @@
>  /**
>   * Test installing a theme
>   */
>  function testInstallTheme() {
> +  persisted.nextTest = "testThemeIsUninstalled";

The next test should be "testThemeIsInstalled"

@@ +108,5 @@
> +function testThemeIsUninstalled() {
> +  addonsManager.open();
> +
> +  var theme = addonsManager.getAddons({attribute: "value",
> +                                       value: THEME.id});

This can stay on the previous line

Comment 3

[Daniela Domnici]

Attachment: patch_V2

Updated patch

Comment 4

[Daniela Domnici]

Attachment: patch_V2

Updated patch

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8537833 [details] [diff] [review]
patch_V2

Review of attachment 8537833 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/9a6705b27149 (default)

Comment 6

[Andreea Matei [:AndreeaMatei]]

We decided to let these refactoring changes ride the trains.