Closed
Bug 1109198
Opened 11 years ago
Closed 11 years ago
Turn on Downloads integration on release builds
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox35 verified, firefox36 verified, firefox37 verified, fennec35+)
VERIFIED
FIXED
Firefox 37
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(1 file)
|
659 bytes,
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
35 is a permissions bump. We should include this permission there.
|
||
Updated•11 years ago
|
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
OS: Mac OS X → Android
Hardware: x86 → ARM
|
Assignee | |
Comment 1•11 years ago
|
||
Turn this on everywhere.
Attachment #8536666 -
Flags: review?(mark.finkle)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8536666 [details] [diff] [review]
Patch
Needs uplift to Fx35 ASAP
Attachment #8536666 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8536666 [details] [diff] [review]
Patch
Approval Request Comment
[Feature/regressing bug #]: Removing build flag (bug 816318)
[User impact if declined]: Downloads don't appear in the Downloads app
[Describe test coverage new/current, TBPL]: No testing
[Risks and why]: Low risk. Has been on nightly for a few months with no problems.
[String/UUID change made/needed]: None
Attachment #8536666 -
Flags: approval-mozilla-beta?
Attachment #8536666 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Ping to get this on the beta. Permission changes hurt and getting them in sooner is best.
Flags: needinfo?(release-mgmt)
Flags: needinfo?(lsblakk)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8536666 [details] [diff] [review]
Patch
I don't see the mozilla-central landing here, but you say it's on Nightly so alright, let's uplift.
Flags: needinfo?(lsblakk)
Attachment #8536666 -
Flags: approval-mozilla-beta?
Attachment #8536666 -
Flags: approval-mozilla-beta+
Attachment #8536666 -
Flags: approval-mozilla-aurora?
Attachment #8536666 -
Flags: approval-mozilla-aurora+
|
|
||
Updated•11 years ago
|
Flags: needinfo?(release-mgmt)
|
|
||
Comment 7•11 years ago
|
||
The feature is on for nightly/aurora because that is how the check works.
|
|
||
Comment 8•11 years ago
|
||
|
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
|
|
||
Updated•11 years ago
|
tracking-fennec: ? → 35+
|
|
||
Comment 11•11 years ago
|
||
Downloaded files using Fennec are listed in Downloads application.
Builds:
Firefox for Android 35.0;
Firefox for Android 36 Beta 2;
Firefox for Android 37.0a2 (2015-01-21);
Device: Samsung Galaxy S4 (Android 4.4.2).
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•