Closed Bug 1109185 Opened 9 years ago Closed 9 years ago

Permissions bump incorrectness for Fennec 35 Beta

Categories

(Firefox for Android Graveyard :: General, defect)

35 Branch
All
Android
defect
Not set
normal

Tracking

(firefox35+ fixed, fennec35+)

VERIFIED FIXED
Tracking Status
firefox35 + fixed
fennec 35+ ---

People

(Reporter: u279076, Unassigned)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]:

It was my understanding that Fennec 35 was to include a permissions bump for downloads and geolocation. As it stands I am not seeing this bump.

1. Install Fennec 34b11
2. Go to the Play store
3. See an update to Firefox Beta
4. Tap "update"
5. See the permissions acceptance UI (image attached)
> There is no mention of changes to downloads or geolocation permissions
I thought I saw some people getting the bump. Brad Lassey asked me about it when he saw it.
Flags: needinfo?(blassey.bugs)
In 35 (m-b) I see:

    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

#ifdef MOZ_ANDROID_DOWNLOADS_INTEGRATION
    <uses-permission android:name="android.permission.DOWNLOAD_WITHOUT_NOTIFICATION" />
#endif


and


mobile/android/confvars.sh

# Enable adding to the system downloads list in pre-release builds.
if test ! "$RELEASE_BUILD"; then
  MOZ_ANDROID_DOWNLOADS_INTEGRATION=1
fi


so beta 35 should have both of these permissions.
OS: Mac OS X → Android
Hardware: x86 → All
Are my steps right? Is there some other user flow I should be checking to see the permissions bump?
(In reply to Richard Newman [:rnewman] from comment #2)

> so beta 35 should have both of these permissions.

Sorry, brain and fingers did different things. Beta 35 should only have ACCESS_FINE_LOCATION.
34.0.5's manifest has:

    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

so I don't see any difference.

Which new permission does the Stumbler need if not ACCESS_FINE_LOCATION?
In release:

#ifndef RELEASE_BUILD
    <uses-permission android:name="android.permission.CHANGE_WIFI_STATE"/>
    <uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>
#endif

in beta this is not conditionalized.
The attached screenshot showing the added request for WiFi access permissions is correct for stumbling. 

The bug for that permission: https://bugzilla.mozilla.org/show_bug.cgi?id=1061991
And Wes is filing the bug for download permissions, which (incorrectly) haven't been de-conditionalized yet.
Flags: needinfo?(blassey.bugs)
(In reply to Richard Newman [:rnewman] from comment #8)
> And Wes is filing the bug for download permissions, which (incorrectly)
> haven't been de-conditionalized yet.

Should we just re-open bug 816318 since this isn't really fixed? My bug can probably be duped to that.
Flags: needinfo?(wjohnston)
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> (In reply to Richard Newman [:rnewman] from comment #8)
> > And Wes is filing the bug for download permissions, which (incorrectly)
> > haven't been de-conditionalized yet.
> 
> Should we just re-open bug 816318 since this isn't really fixed? My bug can
> probably be duped to that.

No. It really is fixed, just not riding the trains correctly. A separate bug is best IMO.
Fair enough. Wes, can you make sure you link the bug to this one?
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #11)
> Fair enough. Wes, can you make sure you link the bug to this one?

Bug 1109198, which is fixed. Marking this fixed too.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(wjohnston)
Resolution: --- → FIXED
tracking-fennec: ? → 35+
Verified on beta 4.
Status: RESOLVED → VERIFIED
Depends on: 1109198
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: