1109353 - [Calendar] Cancelling the removal of an already existing calendar account will prompt an error message and then send the user back to the home screen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[jbolton]

Attachment: CancelRemoveAcctlog.txt

Description:
Cancelling the removal of an already existing calendar account will prompt an error message and then send the user back to the home screen.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141208040202
2)Launch the calender app.
3)Select the drawer icon at the top left hand corner of the screen.
4)Select the gear icon at the bottom left hand corner of the screen.
5)Select one of the already existing calendar accounts (ie. Caldav, Google, Yahoo)
6)Select "remove local data".
7)On the next screen, choose cancel.
8)An error message will appear. Close the message.

  
Actual:
When opting to cancel the removal of the selected account, the user is given an error message. Upon closing this error message, the user is kicked to the home screen.
  
Expected: 
No error message is prompted when the user elects to cancel the account removal. The user is returned to the previous screen.
  
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141208040202
Gaia: 0e429d970c160e580e19e61ad8ff5612de159f00
Gecko: c4c7442e9113
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/3713/
See attached: Video, logcat
https://www.youtube.com/watch?v=-CssEfKokuA&list=UUSKu_I0iIQhvXlOCvmFGPTA

Comment 1

[jbolton]

This issue does not occur on the Flame 2.1 or the Flame 2.0

Actual Result: No error message is prompted when the user elects to cancel the account removal. The user is returned to the previous screen.

Device: Flame 2.1 (319mb) (Kitkat Base)(Full Flash)
BuildID: 20141205001201
Gaia: 38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko: 8b92c4b8f59a
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

- - - - - - - - - - - - - 

Device: Flame 2.0 (319mb) (KitKat Base)(Full Flash)
Build ID: 20141208000206
Gaia: 856863962362030174bae4e03d59c3ebbc182473
Gecko: e40fe21e37f1
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Please note this bug appears to be similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1017811.

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

This is very poor app flow, and is confusing to the end user. Also a regression. Nominating to block 2.2

Comment 3

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window

Last Working

Device: Flame 2.2
BuildID: 20141028120749
Gaia: fede7e11f3786f8944ec5e6b74d8c30f5790c326
Gecko: 7b9e4e834ad4
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken

Device: Flame 2.2
BuildID: 20141028123811
Gaia: 030fd6f09fa72f3d111e5121e7c0af0df97d06f9
Gecko: d4460ff40b88
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: fede7e11f3786f8944ec5e6b74d8c30f5790c326
Gecko: d4460ff40b88

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 030fd6f09fa72f3d111e5121e7c0af0df97d06f9
Gecko: 7b9e4e834ad4

Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/fede7e11f3786f8944ec5e6b74d8c30f5790c326...030fd6f09fa72f3d111e5121e7c0af0df97d06f9

Comment 4

[Joshua Mitchell (Inactive)]

Caused by patch to Bug 1085413 - can you take a look Yura?

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8535384 [details] [review]
Github pull request.

LGTM. thanks!

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/0d36cd249e06bad1cb0847514333ade2c4bba550

Comment 8

[sarsenyev]

Verified the issue is fixed on 2.2 Flame

No error message appears after "cancel" to delete an account in the calendar

"Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141216040205
Gaia: af3d2f89f391c92667e04676fc0ac971e6021bb7
Gecko: a3030140d5df
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0"