Closed
Bug 1109569
Opened 10 years ago
Closed 10 years ago
Add sound notifications to the room paradigm in FxOS Hello
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaoo, Assigned: jaoo)
References
Details
Attachments
(1 file)
Lets add -at least- the same sound notifications that Fx has. See bug 1088650 for more information.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → josea.olivera
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
See Also: → 1088650
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8534556 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/384
Have a look at comment 0 from bug 1088650 as it describes what audio notification the app should have. Let's pair up for the review if you want. Thanks!
Attachment #8534556 -
Flags: review?(borja.bugzilla)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8534556 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/384
Have a look at comment 0 from bug 1088650 as it describes what audio notification the app should have. Let's pair up for the review if you want. Thanks!
Attachment #8534556 -
Flags: review?(borja.bugzilla)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8534556 -
Flags: review?(borja.bugzilla)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8534556 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/384
Great job!
Attachment #8534556 -
Flags: review?(borja.bugzilla) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Thanks!
Landed at:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/5b53e5d70a311a18a8b7f7921532c058e1dab1c2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•