1109636 - [UX] Improve the search panel when suggestions are disabled

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[aleth [:aleth]]

This is an edge case that happens when search engine suggestions are turned off, so the 'suggestions' displayed are hits from the user's search history.

STR
Type a search text that is not in the search history

The search text appears
* in the search box
* as the only suggestion
* in the "search for x with" text

Expected behaviour:
Arguably, three times is a bit much and the "suggestions" top part of the search panel should simply go away when there are no suggestions.

Comment 1

[Florian Quèze [:florian]]

Philipp, I know this was by design, but I also remember you saying "for now". Do you intend to redesign this part of the search panel at some point?

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Yes, »for now« is still the current state.
The UI is still very much in flux and I'd like to defer changing this to a point when it is more stable.

Comment 3

[Ash Grigas]

Attachment: no suggestions bug.png

Treatment for provider tiles when suggestions are turned off. 2 options pending UI review.

Comment 4

[Florian Quèze [:florian]]

There are 2 different cases:
- the search suggestions have been disabled by the user
- the current default search engine doesn't support offering suggestions

I'm not sure if this second case should have a separate UX bug or be handled here, but on the engineering side it likely makes sense to handle the 2 cases at once.

Comment 5

[Ash Grigas]

updating the attachment to reflect copy for that use case.

Comment 6

[Ash Grigas]

Attachment: no suggestions bug.png

please review this not the earlier attachment

Comment 7

[Ash Grigas]

Providers should be sorted by frequency of use to make interaction faster

Comment 8

[Ash Grigas]

sorry ignore comment above - meant for other bug.

Comment 9

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> There are 2 different cases:
> - the search suggestions have been disabled by the user

If the user has decided to turn off search suggestions, it's probably not desired to prompt her to turn them on again every time she searches.

Comment 10

[Ash Grigas]

Attachment: no suggestions v2.png

Updated to remove ability to turn on suggestions inline given they are on by default and it is an explicit action by the user to turn them off.

Comment 11

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8568104 [details]
no suggestions v2.png

I think that works.
So the only change to the status quo is to get rid of the lone suggestion that exactly matches the search string, right?

Comment 12

[Ash Grigas]

(In reply to Philipp Sackl [:phlsa] unavailable until Feb. 23 from comment #11)
> Comment on attachment 8568104 [details]
> no suggestions v2.png
> 
> I think that works.
> So the only change to the status quo is to get rid of the lone suggestion
> that exactly matches the search string, right?

yes that is correct.

Comment 13

[Ash Grigas]

Created implementation ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1136139