Closed Bug 1136139 Opened 5 years ago Closed 4 years ago

[implement] remove suggestions area in search panel when suggestions are disabled or unavailable

Categories

(Firefox :: Search, defect, P3)

x86
macOS
defect
Points:
5

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
40.3 - 11 May
Tracking Status
firefox41 --- verified

People

(Reporter: agrigas, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch][searchui])

Attachments

(1 file, 1 obsolete file)

Build ticket for https://bugzilla.mozilla.org/show_bug.cgi?id=1109636

See attachment on bug 1109636 for UI change.

If user has turned off suggestions or suggestions are not available from their default provider, remove the white space and duplicate search string shown currently.

If history item exists for search string, it should still show even if suggest is off.
Flags: firefox-backlog?
(In reply to agrigas from comment #0)

> If user has turned off suggestions or suggestions are not available from
> their default provider, remove the white space and duplicate search string
> shown currently.
> 
> If history item exists for search string, it should still show even if
> suggest is off.

This just means revert this change: http://hg.mozilla.org/mozilla-central/diff/495a9f216f11/toolkit/components/search/nsSearchSuggestions.js
(In reply to Florian Quèze [:florian] [:flo] (Away until March 11) from comment #1)
> This just means revert this change:
> http://hg.mozilla.org/mozilla-central/diff/495a9f216f11/toolkit/components/
> search/nsSearchSuggestions.js

Is another change needed to ensure that the panel opens anyways, or is that comment just wrong now?
Flags: firefox-backlog? → firefox-backlog+
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #2)
> (In reply to Florian Quèze [:florian] [:flo] (Away until March 11) from
> comment #1)
> > This just means revert this change:
> > http://hg.mozilla.org/mozilla-central/diff/495a9f216f11/toolkit/components/
> > search/nsSearchSuggestions.js
> 
> Is another change needed to ensure that the panel opens anyways, or is that
> comment just wrong now?

Indeed, there's probably another change needed to force-open the panel.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 40.3 - 11 May
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [fxsearch][searchui]
Points: --- → 5
Flags: qe-verify? → qe-verify+
Attached file MozReview Request: bz://1136139/Gijs (obsolete) —
/r/7855 - Bug 1136139 - fix collapsing of search suggestions when there are none, r?florian

Pull down this commit:

hg pull -r 3965a73943aa40f0e1589f32b01e0224716062bb https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8599327 [details]
MozReview Request: bz://1136139/Gijs

/r/7855 - Bug 1136139 - fix collapsing of search suggestions when there are none, r?florian

Pull down this commit:

hg pull -r 3965a73943aa40f0e1589f32b01e0224716062bb https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599327 - Flags: review?(florian)
Comment on attachment 8599327 [details]
MozReview Request: bz://1136139/Gijs

/r/7855 - Bug 1136139 - fix collapsing of search suggestions when there are none, r?florian

Pull down this commit:

hg pull -r 46f43de7fe0123dab166a144db4620a93c080284 https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8599327 [details]
MozReview Request: bz://1136139/Gijs

https://reviewboard.mozilla.org/r/7853/#review7059

Ship It!
Attachment #8599327 - Flags: review?(florian) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/e73e95394f91
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fxsearch][searchui] → [fxsearch][searchui][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e73e95394f91
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fxsearch][searchui][fixed-in-fx-team] → [fxsearch][searchui]
Target Milestone: --- → Firefox 41
QA Contact: petruta.rasa
I have verified this using Nightly 41.0a1 2015-05-26 under Win 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32-bit.
I've found and logged bug 1169220 so I'm marking this one as verified.
Status: RESOLVED → VERIFIED
Attachment #8599327 - Attachment is obsolete: true
Attachment #8619567 - Flags: review+
You need to log in before you can comment on or make changes to this bug.