1109791 - Experiment with dark vibrancy on dark lwthemes.

Status: RESOLVED INVALID

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

Currently we use -moz-mac-vibrancy-light for almost everything (Especially sidebars). However, when using dark lwthemes, it would be cool to switch to the dark style.

I'm about to add a patch that implements this on the mailWindow only, just to see if we should pursue it everywhere. If Richard is okay with it, I'll add it to Compose, Chat, and AB as well.

Comment 1

[Josiah Bruner [:jsbruner]]

Attachment: MozReview Request: bz://1109791/JosiahOne

Comment 2

[Josiah Bruner [:jsbruner]]

/r/1405 - Bug 1109791 - Experiment with dark vibrancy on dark lwthemes. ui-r?=Paenglab

Pull down this commit:

hg pull review -r 84ca8492a5d92138ed834e9ed220ad1a5bfc5c27

Comment 3

[Josiah Bruner [:jsbruner]]

Attachment: Dark Mode

Comment 4

[Josiah Bruner [:jsbruner]]

Attachment: Light Mode

Note that the patch doesn't have perfect logic. It only works if you have either a light lwtheme or a dark one. If you don't have a lwtheme at all, the patch defaults to dark mode (which is wrong)

Comment 5

[Josiah Bruner [:jsbruner]]

/r/1405 - Bug 1109791 - Experiment with dark vibrancy on dark lwthemes. ui-r?=Paenglab

Pull down this commit:

hg pull review -r 25574f6a1318e669f619914116368fcba0b443c1

Comment 6

[Josiah Bruner [:jsbruner]]

There, I fixed the logic.

Comment 7

[Josiah Bruner [:jsbruner]]

Comment on attachment 8534516 [details]
Dark Mode

I need to put the ui-r flag somewhere, may as well be here.

Comment 8

[Richard Marti (:Paenglab)]

https://reviewboard.mozilla.org/r/1405/#review815

Interesting idea!  I like it but I need to sleep over it to make a decition.

::: mail/themes/osx/mail/mailWindow1.css
(Diff revision 2)
> +#folderTree:-moz-lwtheme:not(:-moz-lwtheme-darktext) {

Instead of using :-moz-lwtheme:not(:-moz-lwtheme-darktext) please try :-moz-lwtheme-brighttext. This is more elegant.

::: mail/themes/osx/mail/mailWindow1.css
(Diff revision 2)
> +    color: white;

How about applying this color only to :-moz-lwtheme-brighttext?

I think with -moz-mac-vibrancy-dark the selected treechildren isn't good visible. How about lighten the background with a transparent white instead of a transparent black?

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 8534516 [details]
Dark Mode

Yeah, I think we should try this. But with a better visibility of the selected treeitem.

Comment 10

[Josiah Bruner [:jsbruner]]

/r/1405 - Bug 1109791 - Experiment with dark vibrancy on dark lwthemes. ui-r?=Paenglab

Pull down this commit:

hg pull review -r 9af860dc68897714b630869f202f2448479d8a36

Comment 11

[Josiah Bruner [:jsbruner]]

Attachment: Potential Problem

My latest patch should work properly, but I did notice a potential problem. Some things do use brighttext, even though they aren't really dark themes. I have attached a screenshot of such a theme. It is using the dark vibrancy, but it would perhaps look better to use the light version.

We could claim that the theme should use a different font, but in this case I don't think the author did anything wrong. What do you think Richard?

Comment 12

[Josiah Bruner [:jsbruner]]

It's worth noting though that I do not think the dark looks bad, but that the light vibrancy might look nicer.

Comment 13

[Josiah Bruner [:jsbruner]]

Attachment: More significant potential problem.

Here's a different theme that also uses bright text, but the dark vibrancy looks quite off.

Comment 14

[Richard Marti (:Paenglab)]

When I look at the two screenshots I would say brighttext a wrong decision as the tab title is almost unreadable on selected tab. How does it look with FX, is it using then the white icons?

This are maybe edge cases and on what else would you base the decision (except not implement this bug)? Although TB with dark LW-themes doesn't look so good on OS X without the white button icons, the icons are almost not visible. For OS X lighter dark LW-themes are preferred because of the button icon problem and then the dark folderpane would look weird.

I'm okay, and maybe it's better, when you think this experiment shouldn't be implemented.

Comment 15

[Richard Marti (:Paenglab)]

Comment on attachment 8534508 [details]
MozReview Request: bz://1109791/JosiahOne

I thought a little bit about the problem with the light dark-themes and I think it's better to not implement it now. When TB on OS X has white button icons, we can come back to this because then it would also make more sense to use really dark LW-themes.

Comment 17

[Josiah Bruner [:jsbruner]]

Attachment: MozReview Request: Bug 1109791 - Experiment with dark vibrancy on dark lwthemes. ui-r?=Paenglab

Comment 18

[Wayne Mery (:wsmwk)]

obsolete?

Comment 19

[Alessandro Castellani [:aleca]]

Yes, obsolete.