1110350 - Have TabsPanel and TabsPanelToolbar extend ThemedLinearLayout

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Currently, both TabsPanel and TabsPanelToolbar implement LightweightTheme.OnChangeListener and duplicate a lot of functionality from ThemedLinearLayout.

Extend ThemeLinearLayout in these classes, calling the super methods and removing the code duplication. You should check over all uses of mTheme to ensure some code duplication isn't hiding (e.g. [1]).

Also, remove the mTheme instance variable in favor of using getTheme(), like bug 1110310.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tabs/TabsPanel.java?rev=383988745eb2#282

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via email.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Unassigning due to inactivity - Protyay, let me know if you're still working on this.

Comment 3

[Alexander Dimitrov [:alexxdim94]]

I want to work on this! Do I make TabsPanel and TabsPanelToolbar extend ThemedLinearLayout, instead of LinearLayout. And then remove code duplication and call the super method?

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Right. Let me know if you need anything.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://mail.mozilla.org/pipermail/mobile-firefox-dev/2015-February/001090.html

Comment 6

[Alexander Dimitrov [:alexxdim94]]

Michael, sorry for being absent for a few days. I've been having some issues with my laptop and I was getting it fixed. I will work on this this weekend. :)

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

No worries, Alexander! Take your time!

Comment 8

[askthefactorcamera]

If nobody is working on it? Can I work on It? I am new to open source and I would like to take this as my first bug to work on.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I'm not actively working on FF for Android right now - redirecting to Susheel.

Comment 10

[:sdaswani]

Thanks for your willingness to contribute askthefactorcamera!

I can't guarantee we will be able to review your patch, so I suggest you try to contribute to the following projects:

https://github.com/mozilla-mobile/firefox-tv
https://github.com/mozilla-mobile/fenix
https://github.com/mozilla-mobile/firefox-ios
https://github.com/mozilla-mobile/reference-browser
https://github.com/mozilla-lockbox

Thanks!

Comment 11

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.