Closed Bug 1110559 Opened 10 years ago Closed 10 years ago

"Next" and "Previous" keyboard shortcuts should re-focus the job even if only one failure is shown (and already selected)

Categories

(Tree Management :: Treeherder, defect, P3)

Product:
Tree Management
Component:
Treeherder
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KWierso, Assigned: camd)

References

Details

In TBPL, if there was just one failure shown and is already selected, hitting the 'N' or "P" shortcuts would bring that one failure back into focus, scrolling the page as needed. It doesn't seem to do anything in that case with Treeherder.
Priority: -- → P2
Summary: "Next" and "Previous" keyboard shortcuts should work even if only one failure is shown (and already selected). → "Next" and "Previous" keyboard shortcuts should re-focus the job even if only one failure is shown (and already selected)
Priority: P2 → P3
This is a TBPL feature parity bug and agreed that while not high in severity, it'd probably be pretty easy to fix and would be a nice papercut fix.
Flags: needinfo?(tojonmz)
Makes sense to me. :)
Flags: needinfo?(tojonmz)
Assignee: nobody → cdawson
This should be fixed by the changes for bug 1170577. Works for me locally, and will verify once it's merged and on stage.
Depends on: 1170577
No longer depends on: 1170577
My bad, that isn't the change that fixes this. It's this one that fixed it: https://github.com/mozilla/treeherder/commit/20f14b8099bb945c3ab9599a8544ac7afc132177 Waiting till it's working on stage to mark resolved, though. Works locally for me.
Status: NEW → ASSIGNED
Depends on: 1164545
OK, verified fixed on staging now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.