1110630 - [Flame][Settings]Some functions of app can't work after swiping to switch apps

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_1431.txt

[1.Description]:
[Flame 2.1 & 2.2][Settings]Some functions of app can't work after you back to previous app.
Found time:14:31
See attachment:1431.mp4 and logcat_1431.txt

[2.Testing Steps]: 
Premise: The "Edge swipe navigation" have turned on.
1.Launch Message.
2.Press Home key, then launch Contacts.
3.Swipe screen to left, change to Message app.
4.Before the Message display completely, swipe screen to right, back to Contacts app.
5.Tap create contact button, and then tap settings button.

Note:This issue still exist in all apps.

[3.Expected Result]: 
5. All functions of app should work normally.

[4.Actual Result]: 
5.The create contact button  and some options in settings can't work.

[5.Reproduction build]: 
Flame 2.1 build:
Gaia-Rev        97873dca486abf4162a3345e71b375806937bdec
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-2g34_v2_1/rev/9faa165ac85d
Build-ID        20141211001204
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141211.034507
FW-Date         Thu Dec 11 03:45:22 EST 2014
Bootloader      L1TC00011880

Flame 2.2 build:
Gaia-Rev        1a956437210d2b16988d2ddbf40c9a38d8474435
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/d92db71d4e67
Build-ID        20141211040208
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141211.074025
FW-Date         Thu Dec 11 07:40:36 EST 2014
Bootloader      L1TC00011880

[6.Reproduction Frequency]: 
Always Recurrence,5/5
TCID: Free Test

Comment 1

[Peipei Cheng (needinfo if you need my action)]

lance, could you please also check whether Flame 2.0 and woodduck 2.0m also have this problem?

Comment 2

[Lance（leave from Mozilla）]

(In reply to Peipei Cheng from comment #1)
> lance, could you please also check whether Flame 2.0 and woodduck 2.0m also
> have this problem?

Hi Peipei,
    This issue doesn't exsit on Flame 2.0 and Woodduck 2.0.
Woodduck version:
Gaia-Rev        aa6568e86fdfe5403b7ce4941a5837d310df111e
Gecko-Rev       8d40d6480ee0e628b0f7655dcd6ff79a2f2fbcfc
Build-ID        20141212050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1418331984
FW-Date         Fri Dec 12 05:06:52 CST 2014

Flame 2.0 version:
Gaia-Rev        4887744f873c8aa1ddadd9618e9b79dac259d27d
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-2g32_v2_0/rev/dec2fdd8c4fe
Build-ID        20141211000200
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141211.034247
FW-Date         Thu Dec 11 03:42:58 EST 2014
Bootloader      L1TC00011880

Comment 3

[Peipei Cheng (needinfo if you need my action)]

qawanted to get regression window.

Comment 4

[Lance（leave from Mozilla）]

Attachment: 1431.MP4

Comment 5

[Joshua Mitchell (Inactive)]

adding proper tag

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20141124095744
Gaia: 66d82a2435fb46b7dcb6a367266af967f6ea0145
Gecko: 1d8c71a4d1b6
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20141124103145
Gaia: 072b91a55ce625c8c7681777e0ecd4a4f536bb0e
Gecko: fe62eecb21f8
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia: 072b91a55ce625c8c7681777e0ecd4a4f536bb0e
Gecko: 1d8c71a4d1b6

First Broken Gecko & Last Working Gaia - issue does NOT repro
Gaia: 66d82a2435fb46b7dcb6a367266af967f6ea0145
Gecko: fe62eecb21f8

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/66d82a2435fb46b7dcb6a367266af967f6ea0145...072b91a55ce625c8c7681777e0ecd4a4f536bb0e

Caused by Bug 1096704.

Comment 7

[Joshua Mitchell (Inactive)]

This issue seems caused by the patch for Bug 1096704 - can you take a look Etienne?

Comment 8

[Etienne Segonzac (:etienne)]

Wow, glad we caught this one. Definitely revealed by bug 1096704 but it's actually a bigger issue since we never removed the screenshot/identification overlays (the app just on top of them).

Patch incoming!

Comment 9

[GitHub Autolander Bot]

Attachment: [PullReq] etiennesegonzac:bug-1110630 to mozilla-b2g:master

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8536456 [details] [review]
[PullReq] etiennesegonzac:bug-1110630 to mozilla-b2g:master

r=me

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/bc87e9eb1da6c5526209ef91c9fe91bb3de4237b

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8536456 [details] [review]
[PullReq] etiennesegonzac:bug-1110630 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1096704
[User impact] if declined: using the edge gestures can cause an app to stop reacting to user interactions
[Testing completed]: STRs + STRs from bug 1096704 + unit testing
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none

Note: the root cause here is that the mechanism to hide the screenshot overlay on top of apps was broken (for a while). We didn't catch it earlier because once active the app is displayed on top of this overlay. But with bug 1096704 we prevent the app from getting touch events in this case.

Comment 13

[bhavana bajaj [:bajaj]]

Comment on attachment 8536456 [details] [review]
[PullReq] etiennesegonzac:bug-1110630 to mozilla-b2g:master

BLocking it as this is a functional regression we caused.

Approving the landing and requesting QA verification once this lands on 2.1

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/14315733e2d265a42f9ab02d1aba191789870f70

Comment 15

[sarsenyev]

Verified the issue is fixed on 2.2 Flame

The "Settings option" screen is no longer freezes, and the button is navigating to "Settings" or can be canceled
"Flame 2.2

Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141216040205
Gaia: af3d2f89f391c92667e04676fc0ac971e6021bb7
Gecko: a3030140d5df
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0"
====================================================================
Leaving "verifyme" for 2.1 verification

Comment 16

[KTucker [:KTucker][Inactive 3/4/2016]]

Sergey, can you verify 2.1 please?

Comment 17

[sarsenyev]

The issue is fixed on 2.1 Flame

in Message app, no more freezes occurs in "Settings" options, when swiping apps 

"Flame 2.1

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141217001201
Gaia: 14315733e2d265a42f9ab02d1aba191789870f70
Gecko: ddecea83ce6e
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 34.0 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"