1096704 - [Window Management] Swiping up while edge gesturing causes the user to be stuck on a blank page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: SwipeupEdgeGestureLog.txt

Description:
Swiping up while edge gesturing between windows causes the user to be stuck on a blank page. The user will have to restart their device. The home button will vibrate when pressed but will not take the user to the homescreen. 

Repro Steps:
1)  Updated Flame to Build ID: 20141110001201
2)  Tap on the "Settings" icon and then tap on "Browsing Privacy".
3)  On the "Browsing Privacy" page, tap on the "Rocketbar", type in pizza and tap the search icon on the keyboard.
4)  On the Google browser page that opens up, tap on the "..." and tap on "New window".
5)  Edge gesture back to the "Browsing Privacy" page and perform another search for "Pizza" using the "Rocketbar".
6)  Edge gesture back and forth between all the open windows. While transitioning between windows, do a quick "Swipe up" with your finger like you were closing a window in card view.
7)  Keep performing step 6 until encountering the blank page with the "Rocketbar". 
8)  Tap the "Home button" on the phone while on the blank page.

Actual:
The user will get stuck on a blank white page that contains only the "Rocketbar". Tapping the home button on the phone will not take the user to the homescreen. They will have to restart their device to recover.

Expected:
The user does not get stuck on a blank page and the user can always get to the homescreen when pressing the "Home" button.

Environmental Variables
Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141110001201
Gaia: 0ec1925fc37b7c71d129ae44e42516a0cfb013c4
Gecko: 97487a2d1ee6
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
Repro frequency: 100%
See attached: video clip, logcat,

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not reproduce on the Flame 2.2 or the Flame 2.0

The user does not get stuck on a blank page when swiping up while edge gesturing between windows.

Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141110040206
Gaia: 5f8206bab97cdd7b547cc2c8953cadb2a80a7e11
Gecko: d380166816dd
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141110000204
Gaia: d3e4da377ee448f9c25f908159480e867dfb13f3
Gecko: 7198906837e7
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: Regression, broken functionality (blank page), poor UX

Comment 3

[Gregor Wagner [:gwagner]]

Etienne, can you take a look here?

Comment 4

[Duane Dixon [:ddixon]]

Central Regression Window

Last Working

Device: Flame 2.2
BuildID: 20140926135539
Gaia: e30d373eb5ed0514bce08a3b3d80d71b05a4dc32
Gecko: 16ff803b47a9
Version: 35.0a1 (2.2)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken

Device: Flame 2.2
BuildID: 20140926182541
Gaia: 2834baf4c7e34fe6ef335f0469f6d0f593c5922b
Gecko: a5e456511fe9
Gonk: 
Version: 35.0a1 (2.2)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: e30d373eb5ed0514bce08a3b3d80d71b05a4dc32
Gecko: a5e456511fe9

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 2834baf4c7e34fe6ef335f0469f6d0f593c5922b
Gecko: 16ff803b47a9

Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/e30d373eb5ed0514bce08a3b3d80d71b05a4dc32...2834baf4c7e34fe6ef335f0469f6d0f593c5922b

Possible Cause: 

 bug 1069452 - Never take screenshot of closing AppWindow if part of h…

Comment 5

[Joshua Mitchell (Inactive)]

broken by  bug 1069452 ? Can you take a look Aus?

Comment 6

[Gregor Wagner [:gwagner]]

Broken functionality.

Comment 7

[Aus Lacroix [:aus]]

I'll have a look at this asap. Sounds nasty :(

Etienne, any input you have would be appreciated.

Comment 8

[Etienne Segonzac (:etienne)]

Interesting... 
First: it's possible to expand/collapse the rocketbar while the overlay is displayed on top of a web sheet, we should probably use the touch-blocker div to prevent that.

Then there's the issue that tapping the top left corner will always trigger the rocketbar, even if the currently displayed app is not active. So we're actively looking for edge cases :)

Comment 9

[Etienne Segonzac (:etienne)]

Attachment: 0001-Bug-1096704-Prevent-rocketbar-trigger-during-an-edge.patch

Here's a simple wip.
Will work on tests and check if we should base it on master or be 2.1 only.

Does it fix the issue for everybody?
(the STR are tricky and perf/timing related it seems)

Comment 11

[Aus Lacroix [:aus]]

Comment on attachment 8522901 [details] [diff] [review]
0001-Bug-1096704-Prevent-rocketbar-trigger-during-an-edge.patch

Review of attachment 8522901 [details] [diff] [review]:
-----------------------------------------------------------------

Only one nit, and this patch resolves the issue for me on 2.1. I tried to apply it on 2.2 and unfortunately it doesn't apply cleanly so it will need to be rebased.

::: apps/system/js/rocketbar.js
@@ +272,5 @@
>            // but currently the transition sequence is crucial for performance
>            var app = AppWindowManager.getActiveApp();
>            var afterActivate;
>  
> +          if (app && !app.isActive()) {

It would be nice to add a comment here explaining this check. :)

Comment 12

[Duane Dixon [:ddixon]]

Aus, 

I am testing the patch "bug-1096704" made for this bug.  

I am seeing the same results with AND without the patch being applied in the latest Flame 2.2 build (Full Flash, nightly).  Further, I am seeing the same results you have listed in Comment 11. I am confused as to why I am getting the same results on 2.1 and 2.2 with the patch applied.  Any suggestions? Thanks.

Comment 13

[Etienne Segonzac (:etienne)]

Attachment: Github PR against master

Comment 14

[Aus Lacroix [:aus]]

:ddixon, The patch that was originally posted (https://bugzilla.mozilla.org/attachment.cgi?id=8522901&action=edit) only applies on 2.1.

After doing a full flash of the nightly build you will need to apply the patch to gaia 2.1 branch and do 'make reset-gaia'. If you do not, you will still end up using the code in the original nightly build you flashed.

Comment 15

[Aus Lacroix [:aus]]

:ddixon, one more thing also, the new Pull Request is based on master so you should be able to flash a full nightly (mozilla central! not aurora!), apply the patch to a working gaia master tree and do make reset-gaia.

Comment 16

[Aus Lacroix [:aus]]

Comment on attachment 8523858 [details] [review]
Github PR against master

Looks great! I'm a little concerned that QA didn't see the issue fixed with the original WIP but it fixed the issue for me... This patch does the trick as well on master on my Flame (v188, 319M, latest gecko+gaia+pull request applied).

Comment 17

[Duane Dixon [:ddixon]]

I applied the patch to the latest Flame 2.2 build (Full Flash, nightly, 319 MB). 

1) Applied patch "bug-1096704"
2) Used "make reset-gaia"
3) Restarted my device

Actual Results: Edge gesturing between apps then quickly swiping upwards does not cause the app to freeze or crash. However, an app will sometimes flash a black screen. 

Attached video of my results: "edge_swipe_2.2_with_patch.mpeg"

Environmental Variables:
Device: Flame 2.2
Build ID: 20141117040203
Gaia: 268315b482eb6d00d2a496b8b8eac767dfebda60
Gecko: 21b745197618
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 18

[Duane Dixon [:ddixon]]

URL for new video listed in Comment 17: http://youtu.be/ygG4z_r8A7o

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8523858 [details] [review]
Github PR against master

LGTM

Comment 20

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/118f64988eeb0b5d90c61f31810dde5dcd1b0343

The video looks promising (except for the performance but that's unrelated to this bug), we should make sure this gets dully verified once it reaches 2.1.

Comment 21

[Kevin Grandon :kgrandon]

Backed out for causing integration test failures like "TEST-UNEXPECTED-FAIL | apps/system/test/marionette/global_search_test.js | Global search > Triggering the search from the hot corner". Perhaps this conflicted with something after the try run?

https://tbpl.mozilla.org/php/getParsedLog.php?id=52863805&tree=B2g-Inbound#error0

https://github.com/mozilla-b2g/gaia/commit/d7a0a2b6803d3ac626defc77441ae87f2f580e30

Ni on Etienne, I'm also looking into what might be causing the failures.

Comment 22

[Kevin Grandon :kgrandon]

Attachment: Screenshot of test at point of timeout

Comment 23

[Etienne Segonzac (:etienne)]

Opened a new pull request, I think this was an rebase issue with the landing of the last browser api change fixes, but I'll triple-check :)

https://github.com/mozilla-b2g/gaia/pull/26248

Comment 24

[Kevin Grandon :kgrandon]

Looks like the try runs are passing in both of our PRs. This is weird, but I've re-triggered each a few times. If they end up passing on your run, but fail on b-i, this means we might have some code discrepancy on m-c vs b-i.

Comment 25

[Kevin Grandon :kgrandon]

It seems that both of our try runs are green, so I guess you should go ahead and re-land your PR and pay attention to the tree. If it fails I guess there must be some discrepancy between b-i and m-c. I'd land it now, but I'm not going to be around to watch the tree. Sorry about the backout if it was improper.

Comment 26

[Etienne Segonzac (:etienne)]

Attachment: PR for relanding

new PR to reland this, carrying the r+

Comment 27

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/b6fc3f7038e231e748b5b8cfb46531352e657680

Comment 28

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.1 approval on this when you get a chance.

Comment 29

[Etienne Segonzac (:etienne)]

Comment on attachment 8526806 [details] [review]
PR for relanding

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): the app overlay for edge gestures (I think bug 992081 originally) and the global search (bug 1042083).

[User impact] if declined: while the overlay is displayed it is actually possible to act on the app/on the rocketbar. This itself is pretty minor, but it does expose us to a bunch of rocketbar edge cases where we break pretty badly and the user is stuck until reboot.

[Testing completed]: Rocket bar and edge gestures typical tests + an integration test covering the main race condition.

[Risk to taking this patch] (and alternatives if risky): low-ish, a simple and well tested change is made to a core part of the system app.

[String changes made]: none

Comment 30

[KTucker [:KTucker][Inactive 3/4/2016]]

Duane, please verify this issue is fixed once 2.1 has been uplifted.

Comment 31

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.1 uplift.

Comment 32

[Etienne Segonzac (:etienne)]

Attachment: PR against 2.1

carrying the r+

Comment 33

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/c226db212db4d824c09617cd6dc407b2d4258d9b

Comment 34

[Duane Dixon [:ddixon]]

Issue is verified fixed in latest Flame 2.1, 2.2 builds (Full flash, nightly, 319 MB memory). 

Actual Results: Edge gesturing between apps and quickly swiping upwards does not cause a unresponsive white screen.  

Device: Flame 2.2
BuildID: 20141211040208
Gaia: 1a956437210d2b16988d2ddbf40c9a38d8474435
Gecko: d92db71d4e67
Gonk: 263b5f41f7733c5577fb101eb4dc8ac5c11cfa8d
Version: 37.0a1 (2.2)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1
BuildID: 20141211001204
Gaia: 97873dca486abf4162a3345e71b375806937bdec
Gecko: 9faa165ac85d
Gonk: 263b5f41f7733c5577fb101eb4dc8ac5c11cfa8d
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0