1110693 - Need proper plural form for password age (passwordsDetails.age)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

Description

[Francesco Lodolo [:flod]]

Reference changeset:
http://hg.mozilla.org/mozilla-central/rev/4f270128536a

::: mobile/android/locales/en-US/chrome/aboutPasswords.properties
@@ +1,5 @@
> +# This Source Code Form is subject to the terms of the Mozilla Public
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +passwordsDetails.age=Age: %S days

This is broken even for English (1 days), we need a proper plural form here, especially for locales with complex plural forms.

Also a comment explaining what "Age" means in this context would definitely help.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This part of the code is leftover from a prototype i built. I was using "Age" to show how long it had been since you had updated the password for this login. Old passwords might be more likely to be exposed to others, so updating a password could be seen as good practice.

That said, we may not even ship v1 with this feature.

Comment 2

[:Margaret Leibovic]

Sorry about that, I should have caught that in a review.

That said, this is behind a Nightly build flag for now while we iterate on the UI, and this string will probably change before we ever ship this, since "Age" can also be a confusing label for en-US users.

Comment 3

[Chenxia Liu [:liuche]]

Bug 1144413 will remove the Details page, so I'm going to WONTFIX this bug.