Closed Bug 1144413 Opened 10 years ago Closed 9 years ago

Remove "details" page from about:passwords

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: liuche, Assigned: ally)

References

Details

Attachments

(1 file, 3 obsolete files)

The only actions that should be available on the about:passwords page will be from the context menu: - Copy password (bug 1122225) - Copy username - Edit (bug 1144385) - Delete (bug 1143939) and the details page should be completely eliminated.
Talked to antlam, and this should be similar to the "Add login" page (bug 1128526).
Summary: Remove "Details" page from about:passwords → Update details page of about:passwords
Er, "Edit" in comment 1 links to the wrong bug - that is for Doorhangers. The Edit bug is actually bug 1148524.
Attached image prev_pw_edit_mock1.png (obsolete) —
"details" for a saved login. The awkward white space would normally be covered with a keyboard so I'm not too worried about the vertical alignment. I wanted to hide that in the mock to show the full button for you.
Flags: needinfo?(ally)
Hm, this bug name is a bit confusing, so updating the title. This should only happen after the context menu items are all complete.
Summary: Update details page of about:passwords → Remove "details" page from about:passwords
Comment on attachment 8602395 [details] prev_pw_edit_mock1.png Antlam, I'm moving your mock to bug 1148524. ...I still need to improve my bugfoo-ing, namely naming and keeping bugs discrete x_x
Attachment #8602395 - Attachment is obsolete: true
Depends on: 1148524
Flags: needinfo?(ally)
Assignee: nobody → ally
Attached patch removeDetailsFromAboutPasswords (obsolete) — Splinter Review
I did not remove showDetails() because it is used by onPopupState().
Attachment #8614383 - Flags: feedback?(liuche)
Status: NEW → ASSIGNED
Comment on attachment 8614383 [details] [diff] [review] removeDetailsFromAboutPasswords This bug depends on bug 1148524, so I'm clearing the review flag until that is fixed.
Attachment #8614383 - Flags: feedback?(liuche)
There's also a bug that I just discovered now where "back" on Details doesn't work anymore. But removing the details page will fix that :)
The two bugs are independent of each other. I left the dependency tree as is when I took the bugs over, but I see no technical reason for that relationship
Flags: needinfo?(liuche)
I think the idea is that "Edit login" would replace the Details view, because you'd be able to see all the info about the login. However, now that we added Copy Username/Password, and also Show, the only extra thing that we have is Age which we decided we don't care about anyways. I'm okay with removing this page entirely. To summarize, we should remove _onPopState as well because it's no longer relevant (although you'll need it again for bug 1148524); you should also remove the details-related code from aboutPasswords.xhtml.
No longer depends on: 1148524
Flags: needinfo?(liuche)
updated past about:logins refactor and including all the requests from comment 11.
Attachment #8614383 - Attachment is obsolete: true
Attachment #8621356 - Flags: review?(liuche)
Comment on attachment 8621356 [details] [diff] [review] removeDetailsFromAboutPasswords v2 Review of attachment 8621356 [details] [diff] [review]: ----------------------------------------------------------------- You can also remove the .details css rules in aboutLogins.css. Just a few things to check. ::: mobile/android/chrome/content/aboutLogins.js @@ -346,1 @@ > _openLink: function (clickEvent) { Technically, we don't use this anymore, although we might want to use it later (does "Edit login" in about:logins need it?). I have a slight preference for removing it now and re-adding it later if we need to because then we don't accidentally forget about it, but up to you. The same goes for _getElementForLogin.
Attachment #8621356 - Flags: review?(liuche) → feedback+
Attachment #8621356 - Attachment is obsolete: true
Attachment #8621949 - Flags: review?(liuche)
Attachment #8621949 - Flags: review?(liuche) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: