Closed Bug 1110762 Opened 7 years ago Closed 6 years ago

Add a setCurrentTime method to the AnimationPlayerActor actor

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(1 file, 2 obsolete files)

Now that bug 1096044 has landed, we have web animations actors.
Other than returning the list of animation players for a node and allowing consumers to play/pause animations, they're pretty limited at the moment.

The very next thing to add is the ability to control the current time of an animation player.
Depends on: 1096044
Brian, is there a bug on file already for making currentTime settable on the platform?
The patch you gave me some time ago doesn't apply anymore.
Flags: needinfo?(birtles)
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #1)
> Brian, is there a bug on file already for making currentTime settable on the
> platform?

Yep, bug 1072037.

> The patch you gave me some time ago doesn't apply anymore.

Ok, I'll upload a new one to bug 1072037.
Depends on: 1072037
Flags: needinfo?(birtles)
Blocks: 1105825
Blocks: 1120343
No longer blocks: 1105825
Bug 1072037 isn't marked as fixed yet because it needs a minor extra patch to go first, but the main functionality has landed: animationPlayer.currentTime is now settable!
Comment on attachment 8535595 [details] [diff] [review]
bug1110762-add-setCurrentTime-to-AnimationPlayerActor v1.patch

The code has changed quite a bit since that patch was uploaded. I'll upload a new one soon.
Attachment #8535595 - Attachment is obsolete: true
/r/5371 - Bug 1110762 - Add a setCurrentTime method to the animation actor

Pull down this commit:

hg pull review -r 5c95d3ffda22598b159faa23a521c0c03b9f3ffe
Attachment #8577299 - Flags: review?(past)
Hey Panos, this one is a small one, and the people I usually ask to review animation-actor changes have other reviews from me in their queues :)
Comment on attachment 8577299 [details]
MozReview Request: bz://1110762/pbrosset

https://reviewboard.mozilla.org/r/5369/#review4309

::: toolkit/devtools/server/tests/browser/browser_animation_actors_11.js
(Diff revision 1)
> +  let inspector = InspectorFront(client, form);
> +  let walker = yield inspector.getWalker();
> +  let front = AnimationsFront(client, form);

I would have used "animations" instead of "front" here, but that's OK if you prefer it this way.

::: toolkit/devtools/server/tests/browser/browser_animation_actors_11.js
(Diff revision 1)
> +  ok(state.currentTime >= player.initialState.currentTime,

Wouldn't using > be more correct for this test though? Seeing the same time might indicate the update failed for some reason. Also it's more in line with the next test that seeks backwards and doesn't expect equality.
Attachment #8577299 - Flags: review?(past)
https://hg.mozilla.org/mozilla-central/rev/32152fbd93eb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Attachment #8577299 - Attachment is obsolete: true
Attachment #8618903 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.