1111030 - All views should strip trailing slashes

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Consumer Pages, defect, P5)

Description

[Christopher Van Wiemeersch [:cvan]]

https://marketplace-dev.allizom.org/recommended 200s
https://marketplace-dev.allizom.org/recommended/ 404s

We should strip the trailing slash and redirect.

Comment 1

[Andy McKay]

We should either fix all of them, or not, noting that the same happens for /new/ vs /new, /popular/ vs /popular, /settings/ vs /settings. There's a link there for people to click on that takes them to the right place.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Jason, can you help with this in the nginx routes? Let me know if I should move this bug to Mozilla Services.

Comment 3

[Andy McKay]

Except for things like https://marketplace.firefox.com/developers/, https://marketplace.firefox.com/reviewers/ and pretty much anything that hits Django I presume. Should this be an inclusion list in Fireplace?

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla-services/svcops-puppet/blob/master/modules/marketplace/templates/nginx/marketplace.conf#L279-L303
should match
https://github.com/mozilla/fireplace/blob/master/src/media/js/routes.js#L5-L34

Comment 5

[Andy McKay]

Can we change our dev environments to match? Not keen on changes that affect prod only.

Comment 6

[Devendra]

If it's a [good first bug], I am more than interested to work on it!

Comment 7

[Jason Thomas [:jason]]

Please re-open if this is still needed.