1111047 - Improve theme switching in devtools toolbox

Status: NEW

(DevTools :: Framework, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

From bgrins from bug 1110952#c4 [1]:

We should probably just change how this works from the gDevTools / toolbox level.  Right now the theme-switching.js file waits for a gDevTools notification (that only gets fired from the options panel): http://dxr.mozilla.org/mozilla-central/source/browser/devtools/shared/theme-switching.js#115.

This has the disadvantage of:
1) Extra boilerplate for stuff like this
2) The toolbox doesn't actually switch themes when the pref is changed through about:config

I'd suggest that we add a normal pref listener in gDevTools for the theme that emits the pref-changed handler on itself, then modify the options panel entry to not emit the event so that we don't emit twice.  Then all we would need to do for tests is set the pref.  Not positive if this refactor would break existing tests that rely on the buggy behavior in 2, but it would make this more straightforward.



[1]https://bugzilla.mozilla.org/show_bug.cgi?id=1110952#c4

Comment 1

[Brian Grinstead [:bgrins]]

This is blocking a configuration in mozscreenshots: https://github.com/mnoorenberghe/mozscreenshots/issues/25