1111516 - Implement %TypedArray%.prototype.reverse

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Comment 1

[ziyunfei]

Attachment: bug-1111516-v1.patch

Comment 2

[ziyunfei]

Attachment: added a missed )

Comment 3

[ziyunfei]

Attachment: added `if (typeof newGlobal === "function"){...}`

Comment 4

[Tom S. (please needinfo tschuster)]

Sorry, I will try to review this in 24hours.

Comment 5

[Tom S. (please needinfo tschuster)]

Comment on attachment 8537839 [details] [diff] [review]
added `if (typeof newGlobal === "function"){...}`

Review of attachment 8537839 [details] [diff] [review]:
-----------------------------------------------------------------

Looks perfect, can't really think of anything, but adding a few more step annotations.

::: js/src/builtin/TypedArray.js
@@ +175,5 @@
> +    // Step 6.
> +    var middle = std_Math_floor(len / 2);
> +
> +    // Steps 7-8.
> +    // Omit some steps, since there are no holes in typed arrays.

// Especially all the HasProperty/*exists checks always succeed.

@@ +177,5 @@
> +
> +    // Steps 7-8.
> +    // Omit some steps, since there are no holes in typed arrays.
> +    for (var lower = 0, upper, temp; lower !== middle; lower++) {
> +        upper = len - lower - 1;

// a.
var upper =

@@ +178,5 @@
> +    // Steps 7-8.
> +    // Omit some steps, since there are no holes in typed arrays.
> +    for (var lower = 0, upper, temp; lower !== middle; lower++) {
> +        upper = len - lower - 1;
> +        temp = O[lower];

var lowerValue = O[lower];
var upperValue = O[upper];

// We always end up in the j. case
O[lower] = ..
...

::: js/src/tests/ecma_6/TypedArray/reverse.js
@@ +14,5 @@
> +
> +    assertDeepEq(constructor.prototype.reverse.length, 0);
> +
> +    assertDeepEq(new constructor().reverse(), new constructor());
> +    assertDeepEq(new constructor(1000).reverse(), new constructor(1000));

I think 10 is probably enough.

Comment 6

[ziyunfei]

Attachment: review comment addressed

Comment 7

[ziyunfei]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4aa64338db35

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3cce6766ed6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e3cce6766ed6

Comment 10

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/reverse
https://developer.mozilla.org/en-US/Firefox/Releases/37#JavaScript