Closed
Bug 1111682
Opened 10 years ago
Closed 10 years ago
Update deps for mozbase packages
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [mozmill-2.1+])
Attachments
(1 file)
|
3.02 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
We have to update some deps especially for mozrunner 6.6 to be able to continue with bug 970594. If we don't do that we have both ManifestDestiny and manifestparser installed, which is plainly broken because the code in manifestparser 0.8 is not used.
|
Assignee | |
Comment 1•10 years ago
|
||
Looks like hit other problems with mozrunner after its refactoring now. :( I hope that we can get them fixed in time, so that we are getting unblocked here.
Depends on: 1111727
|
|
Assignee | |
Comment 2•10 years ago
|
||
With this patch we upgrade to the latest mozrunner 6.7 (still needs to be released) and its refactored runner creation. Given that it doesn't check the environment variable anymore, we have to do that on our own. For ease of use, I also added the binary parameter to the create() method.
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8537373 [details] [diff] [review]
Patch v1
Review of attachment 8537373 [details] [diff] [review]:
-----------------------------------------------------------------
Lgtm!
Attachment #8537373 -
Flags: review?(ahalberstadt) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•