1111686 - Re-add Web App manifest to main Discourse

Status: RESOLVED FIXED

(Infrastructure & Operations :: Community IT: Discourse, task)

Description

[Yousef Alam [:yalam96] (use NEEDINFO)]

We removed the web app manifest for Discourse back when we had docker issues, but we should put it back in now.

Comment 1

[Yousef Alam [:yalam96] (use NEEDINFO)]

Also useful https://developer.mozilla.org/en-US/Apps/Build/Manifest#Serving_from_nginx

Comment 2

[Tanner Filip [:tanner]]

It exists, we just have to change the nginx config to serve it as a webapp manifest. https://discourse.mozilla-community.org/manifest.webapp

Comment 3

[Tanner Filip [:tanner]]

Also, let's serve images from CloudFront instead of our own container, that way it's one less thing we need to check each time we deploy.

Comment 4

[Leo McArdle [:leo]]

The results of the Firefox Marketplace manifest validator should be useful: https://marketplace.firefox.com/developers/upload/9975eb6c51274e868076c7afeb90a9fa

It looks like it's just the 404ing images and the nonproper serving of the manifest.

Comment 5

[Leo McArdle [:leo]]

Also, if we want chrome to appear in the app (so users can use a back button), we'll want to add this to the manifest:

"chrome": { "navigation": true }

Comment 6

[Leo McArdle [:leo]]

(In reply to Leo McArdle [:leo] from comment #5)
> Also, if we want chrome to appear in the app (so users can use a back
> button), we'll want to add this to the manifest:
> 
> "chrome": { "navigation": true }

Added the above to the manifest: https://github.com/Mozilla-cIT/discourse-mozilla-extras/blob/master/public/manifest.webapp

Comment 7

[Tanner Filip [:tanner]]

Done on staging.

The following block should be added to app.yml:

  - exec:
        cd: $home/public
        cmd:
          - wget https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/master/public/manifest.webapp
  - exec:
        cd: $home/public/images
          - wget https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/master/public/images/icon-128v2.png
          - wget https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/master/public/images/icon-90.png
          - wget https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/master/public/images/icon-60.png
          - wget https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/master/public/images/icon-32.png
  - exec: sed -i "s/types {/types {\n application\/x-web-app-manifest+json   webapp\;/" /etc/nginx/conf.d/discourse.conf

Comment 8

[Tanner Filip [:tanner]]

(In reply to Tanner Filip [:tanner] from comment #7)
> Done on staging.
> 
> The following block should be added to app.yml:
> 
>   - exec:
>         cd: $home/public
>         cmd:
>           - wget
> https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/
> master/public/manifest.webapp
>   - exec:
>         cd: $home/public/images
>           - wget
> https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/
> master/public/images/icon-128v2.png
>           - wget
> https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/
> master/public/images/icon-90.png
>           - wget
> https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/
> master/public/images/icon-60.png
>           - wget
> https://raw.githubusercontent.com/Mozilla-cIT/discourse-mozilla-extras/
> master/public/images/icon-32.png
>   - exec: sed -i "s/types {/types {\n application\/x-web-app-manifest+json  
> webapp\;/" /etc/nginx/conf.d/discourse.conf

To the bottom. Add it to the bottom of app.yml

Comment 9

[Yousef Alam [:yalam96] (use NEEDINFO)]

This is working again on our end, just waiting for marketplace review