1111743 - Annotate Shumway functions to be inlined

Status: RESOLVED INCOMPLETE

(Firefox Graveyard :: Shumway, defect)

Description

[Chris Peterson [:cpeterson]]

From Shumway meeting on 2014-12-09:
https://etherpad.mozilla.org/shumwaymeeting

Is this for Shumway's own TS code and/or the Shumway JIT's generated JS code?

Comment 1

[Till Schneidereit [:till]]

This is for Shumway's own code: the idea is to add annotations to the source and to modify our version of the Closure Compiler to make it inline the annotated functions.

Comment 2

[Tobias Schneider [:tobytailor]]

Support for doing this landed in https://github.com/mozilla/shumway/pull/2127. Do we want to keep this ticket open as some sort of meta ticket to track the actual work of annotating all the functions we want to have being inlined?

Comment 3

[Chris Peterson [:cpeterson]]

Now that you've landed Closure support for inline functions, I think it makes sense to keep this bug open for a first pass annotating some obvious hotspots. After that, I don't think there would be much value to keep this bug open as a meta bug for all future inline function annotations. I assume future annotations would be the result of guided profiling of specific performance problems or as a part of normal feature development.

Comment 4

[Till Schneidereit [:till]]

I concur.