1111818 - Remove favicon from phone toolbar

Status: RESOLVED DUPLICATE of bug 1018994

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To make it more consistent w/ desktop and new tablet's behavior, i.e. the site identity globe sits there when there is no identity info, and it is replaced with a shield or lock depending on the identity state.

Note: we should probably move the favicon somewhere else (e.g. tabs tray, site identity popup).

NI :antlam so he can talk to Madhava and confirm.

Blocking bug 1107591 because it can be WONTFIX if we decide to go through with this.

Comment 1

[:Margaret Leibovic]

I started a patch that does this when working on bug 1107591.

For consistency with tablets, phishing protection, and performance, I think this bug could be a good win. I can post a test build if that will help us decide if we want to go in this direction.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Gah, didn't see this earlier and it looks like a lot of folks are on PTO (Madhava). 
A test build would be great. Thanks Margaret!

Comment 3

[:Margaret Leibovic]

Here's a build with the patch I was working on:
http://people.mozilla.org/~mleibovic/tmp/no-favicon.apk

It looks like the globe icon is a bit too small on my phone, so there are some scaling issues to resolve, but this generally goes in the direction we've been discussing. Let me know what you think!

Comment 4

[Richard Newman [:rnewman]]

I'd love to know if this is the approach we want to take on iOS, too.

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

After using this a bit, I'm ok with the favicon being moved. As mentioned, this is more consistent with our other UI and it helps us with cleaning up the URL bar (that we've been meaning to do). 

I do notice the scaling issue as well, so should clean that up. Currently, I am also thinking about how we can resurface the favicon in other parts like our doorhangers.

NI-ing Madhava here since this is a substantial change, just to get it on his radar too.

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Talking about this a bit more, we may want to hold off on this until we figure out a way to resurface the favicon in other places of our UI, and that we want to remove it for good. Reason being - this touches on a lot of other things like Task Continuity (e.g. the favicon is a dominant element in our UI for recall), sharing overlay work and iOS.

Consistency is a concern but the context seems different on Mobile. It's not in the URL bar in Tablet/Desktop but it's still present (which is why I want to figure out a place to move it before we remove it) and it gives a nice human aspect to our UI.

Will work with Darrin going forward to address those things and figure out how to move forward

Comment 7

[:Margaret Leibovic]

In this case, I think we should go ahead and just fix bug 1107591 in the meantime.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Fixed by bug 1018994.