1114508 - The Mixed Content Blocking shield icon is smaller

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Flaviu Cos]

Attachment: blocking shield.png

Environment: 
Device: Nexus 4 (Android 4.4.4);
Build: Nightly 37.0a1 (2014-12-21);

Steps to reproduce:
1. Go to https://ie.microsoft.com/testdrive/browser/mixedcontent/assets/woodgrove.htm
2. Tap on 'I understand the risks';
3. Tap on 'Visit site'.
4. Observe the Mixed Content Blocking shield icon from the URL bar.

Expected result:
The blocking shield icon is the same size as the other icons from the URL bar. 

Actual result:
The blocking shield icon is smaller that the other icons.

Notes:
Please check the attached screenshot.

Comment 1

[:Margaret Leibovic]

This would be addressed if we fix bug 1111818.

I think the smaller icon may actually be intentional, though.

Comment 2

[u421692]

Could this might be an issue from the split apk, since Firefox 34 is not affected? Drawables issue on resource-constrained builds?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mihai Pop from comment #2)
> Could this might be an issue from the split apk, since Firefox 34 is not
> affected? Drawables issue on resource-constrained builds?

I did change some shared files around the toolbar while working on new tablet. While the new toolbar is shipping in 36, some of the prior changes may have ended up in 35.

I specifically tested the lock icon, but not the shield (it seems it may have been added later). I think I added some whitespace to the lock images to change the size they scaled to.

NI self to investigate.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Doesn't look like there's any whitespace - I think I may have changed the whitespace on tablet actually.

However, I think the issue is that the icons are scaled and the ratios are not identical, leading to different scaling:

$: identify drawable-mdpi/lock_*     
drawable-mdpi/lock_identified.png PNG 12x15 20x20+4+2 8-bit sRGB 533B 0.000u 0:00.000
drawable-mdpi/lock_verified.png[1] PNG 12x15 20x20+4+2 8-bit sRGB 476B 0.000u 0:00.000

$: identify drawable-mdpi/shield_disabled.png 
drawable-mdpi/shield_disabled.png PNG 16x18 16x18+0+0 8-bit sRGB 853B 0.000u 0:00.000

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Looking at this again, it seems like the icon is smaller than the asset I generated from my mocks. Michael, you mentioned there might be some padding being applied here in the code. 

Can you take a look again to see what's happening?

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Anthony, looks like we got some new assets with the tracking protection work – is this still a problem?

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Nope