1111855 - Trying to close a pinned tab with the keyboard (ctrl-f4, ctrl/cmd-w) should give some kind of feedback about why it "doesn't do anything"

Status: RESOLVED DUPLICATE of bug 1420601

(Firefox :: Tabbed Browser, defect)

Description

[Tiffanie Shakespeare [:tif]]

STR:
1. Launch browser on desktop
2. Open a page and pin to tab bar
3. Hit cmd-w with pin tab in foreground

Actual
Nothing happens

Expected
I understand the elimination of the command so that people don't accidentally close the pinned tab. However, rather than no feedback, the user should be shown some feedback so that they understand functionality is purposeful rather than broken. Doing this could also provide a mechanism for those who do want to close the tab.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I agree that it's strange to not show any feedback here.

Comment 2

[:Gijs (out for now; he/him)]

Blake, any chance you could help figure out what to do here UI-wise? Most of our information mechanisms seem too heavy-handed, except perhaps a notification bar with a timeout? Does that sound sane?

Comment 3

[Blake Winton (:bwinton) (:☕️)]

I wonder if we need the feedback to be that informational.

So, I'm sure the Tart people are going to hate me for this, but what about just gently shaking the tab?  Something like http://codepen.io/anon/pen/vEgpZP maybe?

Or perhaps it would be better to shrink and expand it, as if it was trying to close and then bouncing back open…

(Cc-ing Philipp for more sane ideas.  ;)

Comment 4

[Dão Gottwald [:dao]]

(In reply to Blake Winton (:bwinton) from comment #3)
> So, I'm sure the Tart people are going to hate me for this, but what about
> just gently shaking the tab?  Something like
> http://codepen.io/anon/pen/vEgpZP maybe?
> 
> Or perhaps it would be better to shrink and expand it, as if it was trying
> to close and then bouncing back open…

This feedback, but not the kind of feedback that explains anything. That's not to say that I agree that we need such feedback...

If we don't want to explain why the tab doesn't close, then the standard response when trying to execute a disabled keyboard shortcut would be a beep, at least on some OSes.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #4)
> This feedback, but not the kind of feedback that explains anything.

should have been: This *is* feedback, but [...]