Include Amharic Font in Firefox OS

RESOLVED FIXED in FxOS-S2 (10Jul)

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: arky, Assigned: arky)

Tracking

unspecified
FxOS-S2 (10Jul)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8536948 [details]
NotoSansEthiopic-Regular.ttf

Please include Noto Sans Ethiopic font in Firefox OS. The font cover Amharic, Blin, Geez, Tigre, Tigrinya, Wolaytta scripts.

The Noto fonts are released under the Apache License, version 2.0. 

Font Download page: https://www.google.com/get/noto/#/family/noto-sans-ethi
(Assignee)

Comment 1

4 years ago
Created attachment 8536950 [details]
NotoSansEthiopic-Bold.ttf
(Assignee)

Comment 2

4 years ago
Created attachment 8536955 [details] [diff] [review]
Patch to add Amharic font to Firefox OS

The corresponding PR is https://github.com/mozilla-b2g/moztt/pull/59
Attachment #8536955 - Flags: review?(mwu)
Attachment #8536955 - Flags: feedback?(jfkthame)
Comment on attachment 8536955 [details] [diff] [review]
Patch to add Amharic font to Firefox OS

Looks fine to me. In general, I would like us to have support for all scripts everywhere. I think the only real issue here will be the usual concern about the footprint on the device; every script we add makes the overall system image larger.

(We really need an architecture where end users can add or remove support for scripts and languages on demand, according to their individual needs, rather than requiring us or the device vendor make the call as to what's included.)
Attachment #8536955 - Flags: feedback?(jfkthame) → feedback+

Comment 4

4 years ago
Comment on attachment 8536955 [details] [diff] [review]
Patch to add Amharic font to Firefox OS

I think we'll also need to add OTF versions of this font if you want to use the TTF_EXT file ending. PRs are also preferred.
Attachment #8536955 - Flags: review?(mwu)

Comment 5

4 years ago
(In reply to Jonathan Kew (:jfkthame) from comment #3)
> (We really need an architecture where end users can add or remove support
> for scripts and languages on demand, according to their individual needs,
> rather than requiring us or the device vendor make the call as to what's
> included.)

I feel like that was a very Tarako specific problem. We haven't had any other devices where device space was low enough to start cutting fonts. If we can get a script working by default, why not?
(Assignee)

Comment 6

4 years ago
Noto release contains only TTF fonts. What's the process converting them to Woff? 

https://www.google.com/get/noto/#/family/noto-sans-ethi
Flags: needinfo?(jfkthame)
Personally, I just use the sfnt2woff tool:
  http://people.mozilla.org/~jkew/woff/sfnt2woff (OS X)
  http://people.mozilla.org/~jkew/woff/sfnt2woff.exe (windows)
Source available via github:
  https://github.com/ppicazo/sfnt2woff

Or there are many more sophisticated tools and online services that will convert fonts to woff format:
  https://www.google.com/search?q=convert+ttf+to+woff
Just be sure to use a converter that preserves the complete font, not one that picks subsets of glyphs, etc.
Flags: needinfo?(jfkthame)
(Assignee)

Comment 8

4 years ago
Thank you Jonathan. I have updated the PR request.
 
https://github.com/mozilla-b2g/moztt/pull/59
Hey guys, what's the status on this please? Can we get the patch to land soon? We'd like to add Amharic to fxOS languages asap (this blocks Bug 1180023), as it's almost completely translated. Thanks!
Flags: needinfo?(jfkthame)
Flags: needinfo?(hitmanarky)
Comment on attachment 8536955 [details] [diff] [review]
Patch to add Amharic font to Firefox OS

I don't know any reason this shouldn't land in moztt.... flagging :mwu to review and merge if he thinks it's OK.
Flags: needinfo?(jfkthame)
Attachment #8536955 - Flags: review?(mwu)

Comment 11

3 years ago
Created attachment 8631215 [details] [review]
Amharic font PR
Attachment #8536955 - Attachment is obsolete: true
Attachment #8536955 - Flags: review?(mwu)

Comment 12

3 years ago
Comment on attachment 8631215 [details] [review]
Amharic font PR

No objections here.
Attachment #8631215 - Flags: review+
(Assignee)

Comment 13

3 years ago
Thanks @jfkthame @delphine. It would be great to have Amharic font integrated.
Flags: needinfo?(hitmanarky)

Updated

3 years ago
Assignee: nobody → hitmanarky
Keywords: checkin-needed
https://github.com/mozilla-b2g/moztt/commit/657894b4a1dc0a926117f4812e0940229f9f676f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S2 (10Jul)
(Assignee)

Comment 15

3 years ago
Thank you @mwu @Tomcat for the merge.
You need to log in before you can comment on or make changes to this bug.